gh-106368: Increase Argument Clinic test coverage #106728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erlend-aasland
commented
Jul 13, 2023
•
erlend-aasland
commented
- improve output_parameter() coverage
- improve coverage for Function.kind
- Issue: Increase Argument Clinic test coverage #106368
erlend-aasland
added
needs backport to 3.11
|
I'm probably not the best reviewer for this one, but this all looks reasonable! |
Thanks! I'll expand this PR so we've got better coverage for your FunctionKind PR. |
erlend-aasland
changed the title
|
With this, we're up to approx. 86% test coverage. |
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @erlend-aasland, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 13, 2023
) - improve output_parameter() coverage - improve coverage for Function.kind (cherry picked from commit ec45c51) Co-authored-by: Erlend E. Aasland <[email protected]>
|
GH-106730 is a backport of this pull request to the 3.12 branch. |
|
GH-106731 is a backport of this pull request to the 3.11 branch. |
erlend-aasland
added a commit
that referenced
this pull request
Jul 13, 2023
…106730) - improve output_parameter() coverage - improve coverage for Function.kind (cherry picked from commit ec45c51) Co-authored-by: Erlend E. Aasland <[email protected]>
This comment was marked as off-topic.
This comment was marked as off-topic.
erlend-aasland
added a commit
that referenced
this pull request
Jul 13, 2023
…106731) - improve output_parameter() coverage - improve coverage for Function.kind (cherry picked from commit ec45c51) Co-authored-by: Erlend E. Aasland <[email protected]> * Fix merge
This comment was marked as off-topic.
This comment was marked as off-topic.
kgdiem
pushed a commit
to kgdiem/cpython
that referenced
this pull request
Jul 14, 2023
- improve output_parameter() coverage - improve coverage for Function.kind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.