Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106368: Increase coverage for Argument Clinic output directive #106979

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 21, 2023

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question is not blocking :)
Thanks!

Lib/test/test_clinic.py Show resolved Hide resolved
@erlend-aasland
Copy link
Contributor Author

Thanks for the reviews!

@erlend-aasland erlend-aasland enabled auto-merge (squash) July 22, 2023 09:06
@erlend-aasland erlend-aasland merged commit ee5c01b into python:main Jul 22, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ee5c01b473eeadb007b9f330db3143e34e46038b 3.11

@bedevere-bot
Copy link

GH-106994 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2023
@bedevere-bot
Copy link

GH-107002 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 22, 2023
ambv pushed a commit to ambv/cpython that referenced this pull request Jul 22, 2023
…directive (pythonGH-106979)

(cherry picked from commit ee5c01b)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jul 22, 2023
…ive (GH-106979) (#106994)

(cherry picked from commit ee5c01b)

Co-authored-by: Erlend E. Aasland <[email protected]>
@erlend-aasland
Copy link
Contributor Author

I'll fix the backport later, unless someone beats me to it :)

ambv added a commit that referenced this pull request Jul 22, 2023
…ive (GH-106979) (#107002)

(cherry picked from commit ee5c01b)

Co-authored-by: Erlend E. Aasland <[email protected]>
@erlend-aasland erlend-aasland deleted the clinic/coverage-output-directive branch July 22, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants