-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-106368: Clean up Argument Clinic tests #106373
gh-106368: Clean up Argument Clinic tests #106373
Conversation
erlend-aasland
commented
Jul 3, 2023
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: Increase Argument Clinic test coverage #106368
If we're going to increase coverage for Argument Clinic, we need to clean up the test code a little bit; we need readable tests, and we need to be able to debug existing tests without pulling our hair. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, in my opinion, it is much more readable now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
After gh-106373, we should make the |
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, @erlend-aasland, I could not cleanly backport this to |
Sorry @erlend-aasland, I had trouble checking out the |
GH-106379 is a backport of this pull request to the 3.12 branch. |
(cherry picked from commit 3ee8dac) Co-authored-by: Erlend E. Aasland <[email protected]>
(cherry picked from commit 3ee8dac) Co-authored-by: Erlend E. Aasland <[email protected]>
GH-106381 is a backport of this pull request to the 3.11 branch. |
* main: pythongh-106368: Increase Argument Clinic test coverage (python#106389) pythongh-106320: Fix _PyImport_GetModuleAttr() declaration (python#106386) pythongh-106368: Harden Argument Clinic parser tests (python#106384) pythongh-106320: Remove private _PyImport C API functions (python#106383) pythongh-86085: Remove _PyCodec_Forget() declaration (python#106377) pythongh-106320: Remove more private _PyUnicode C API functions (python#106382) pythongh-104050: Annotate more Argument Clinic DSLParser state methods (python#106376) pythongh-106368: Clean up Argument Clinic tests (python#106373)