Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDKv2 Detailed Diff tests for Computed properties in sets #2740

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Dec 12, 2024

This PR adds tests around Computed properties in Sets for SDKv2, similar to what we have on the PF side.

set attributes:

  • with computed
  • with computed and force new

For the block tests each test has a variant with the computed property unspecified in the program and one where the property is specified in the user program.
set blocks:

  • with computed at the top level
  • with computed at the top level and ForceNew at the top level
  • with computed at the top level and a nested ForceNew
  • with computed at the nested level
  • with computed at the nested level and ForceNew at the top level
  • with computed at the nested level and a nested ForceNew

necessary for #2528
some of the tests are skipped due to #2726

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.64%. Comparing base (f94f380) to head (bd80587).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2740   +/-   ##
=======================================
  Coverage   69.64%   69.64%           
=======================================
  Files         301      301           
  Lines       38726    38726           
=======================================
  Hits        26969    26969           
  Misses      10240    10240           
  Partials     1517     1517           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov marked this pull request as draft December 12, 2024 15:40
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_lists_many_elements branch from 7c0b26d to d7e5748 Compare December 13, 2024 16:33
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from 7c5f7c4 to d8b1526 Compare December 13, 2024 16:34
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_lists_many_elements branch from d7e5748 to 9ce613b Compare December 13, 2024 17:42
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from d8b1526 to bd80587 Compare December 13, 2024 17:42
Base automatically changed from vvm/sdkv2_detailed_diff_lists_many_elements to master December 13, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant