Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SDKv2 set detailed diff tests #2721

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Dec 11, 2024

This is a refactor of the SDKv2 detailed diff tests for sets. Instead of recording them inline, we now run them as cross-tests and record them in separate files along with the name of the test and the input values. This mimics what we did for the PF detailed diff tests in #2592

I've gone through the recordings and believe all of them are correct.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.63%. Comparing base (7b3ace6) to head (e04c35f).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2721      +/-   ##
==========================================
- Coverage   69.63%   69.63%   -0.01%     
==========================================
  Files         301      301              
  Lines       38725    38725              
==========================================
- Hits        26967    26965       -2     
- Misses      10240    10243       +3     
+ Partials     1518     1517       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Base automatically changed from vvm/sdkv2_diff_cross_test_interface to master December 13, 2024 14:01
@VenelinMartinov VenelinMartinov merged commit 8eb33e0 into master Dec 13, 2024
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/refactor_sdkv2_set_detailed_diff_tests branch December 13, 2024 14:02
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.98.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants