-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SDKv2 set detailed diff tests #2721
Refactor SDKv2 set detailed diff tests #2721
Conversation
This change is part of the following stack:
Change managed by git-spice. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2721 +/- ##
==========================================
- Coverage 69.63% 69.63% -0.01%
==========================================
Files 301 301
Lines 38725 38725
==========================================
- Hits 26967 26965 -2
- Misses 10240 10243 +3
+ Partials 1518 1517 -1 ☔ View full report in Codecov by Sentry. |
580f476
to
1668a0c
Compare
63bb605
to
1a68ff8
Compare
1668a0c
to
899f5d0
Compare
1a68ff8
to
3a2e7a4
Compare
899f5d0
to
5fec1c6
Compare
3a2e7a4
to
e04c35f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
This PR has been shipped in release v3.98.0. |
This is a refactor of the SDKv2 detailed diff tests for sets. Instead of recording them inline, we now run them as cross-tests and record them in separate files along with the name of the test and the input values. This mimics what we did for the PF detailed diff tests in #2592
I've gone through the recordings and believe all of them are correct.