Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SDKv2 non-set detailed diff tests #2725

Merged

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Dec 11, 2024

This is a refactors the rest of the SDKv2 detailed diff tests. Instead of recording them inline, we now run them as cross-tests and record them in separate files along with the name of the test and the input values. This mimics what we did for the PF detailed diff tests in #2592

I've gone through the recordings and believe all of them are correct.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.64%. Comparing base (5b45441) to head (047f405).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2725   +/-   ##
=======================================
  Coverage   69.64%   69.64%           
=======================================
  Files         301      301           
  Lines       38726    38726           
=======================================
  Hits        26971    26971           
  Misses      10237    10237           
  Partials     1518     1518           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_non_set_detailed_diff_tests branch from fbc853d to 5f767d8 Compare December 11, 2024 17:51
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_set_replace branch from e34124f to 77ebeec Compare December 11, 2024 18:05
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_non_set_detailed_diff_tests branch from 5f767d8 to 4b0d722 Compare December 11, 2024 18:05
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_non_set_detailed_diff_tests branch from 4b0d722 to c9a31d9 Compare December 11, 2024 18:12
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_set_replace branch from 77ebeec to eddfb59 Compare December 12, 2024 11:42
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_non_set_detailed_diff_tests branch from c9a31d9 to d603038 Compare December 12, 2024 11:42
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_set_replace branch from eddfb59 to 7345fe0 Compare December 12, 2024 12:39
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_non_set_detailed_diff_tests branch from d603038 to 07b28a8 Compare December 12, 2024 12:39
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_set_replace branch from 7345fe0 to b2b8cf9 Compare December 12, 2024 15:20
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_non_set_detailed_diff_tests branch from 07b28a8 to c411570 Compare December 12, 2024 15:20
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_set_replace branch from b2b8cf9 to d168ffb Compare December 13, 2024 16:33
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_non_set_detailed_diff_tests branch from c411570 to 047f405 Compare December 13, 2024 16:33
Base automatically changed from vvm/sdkv2_detailed_diff_set_replace to master December 13, 2024 17:40
@VenelinMartinov VenelinMartinov merged commit f94f380 into master Dec 13, 2024
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/refactor_sdkv2_non_set_detailed_diff_tests branch December 13, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants