-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SDKv2 non-set detailed diff tests #2725
Merged
VenelinMartinov
merged 4 commits into
master
from
vvm/refactor_sdkv2_non_set_detailed_diff_tests
Dec 13, 2024
Merged
Refactor SDKv2 non-set detailed diff tests #2725
VenelinMartinov
merged 4 commits into
master
from
vvm/refactor_sdkv2_non_set_detailed_diff_tests
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is part of the following stack:
Change managed by git-spice. |
This was referenced Dec 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2725 +/- ##
=======================================
Coverage 69.64% 69.64%
=======================================
Files 301 301
Lines 38726 38726
=======================================
Hits 26971 26971
Misses 10237 10237
Partials 1518 1518 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
force-pushed
the
vvm/refactor_sdkv2_non_set_detailed_diff_tests
branch
from
December 11, 2024 17:51
fbc853d
to
5f767d8
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_detailed_diff_set_replace
branch
from
December 11, 2024 18:05
e34124f
to
77ebeec
Compare
VenelinMartinov
force-pushed
the
vvm/refactor_sdkv2_non_set_detailed_diff_tests
branch
from
December 11, 2024 18:05
5f767d8
to
4b0d722
Compare
VenelinMartinov
force-pushed
the
vvm/refactor_sdkv2_non_set_detailed_diff_tests
branch
from
December 11, 2024 18:12
4b0d722
to
c9a31d9
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_detailed_diff_set_replace
branch
from
December 12, 2024 11:42
77ebeec
to
eddfb59
Compare
VenelinMartinov
force-pushed
the
vvm/refactor_sdkv2_non_set_detailed_diff_tests
branch
from
December 12, 2024 11:42
c9a31d9
to
d603038
Compare
This was referenced Dec 12, 2024
VenelinMartinov
force-pushed
the
vvm/sdkv2_detailed_diff_set_replace
branch
from
December 12, 2024 12:39
eddfb59
to
7345fe0
Compare
VenelinMartinov
force-pushed
the
vvm/refactor_sdkv2_non_set_detailed_diff_tests
branch
from
December 12, 2024 12:39
d603038
to
07b28a8
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_detailed_diff_set_replace
branch
from
December 12, 2024 15:20
7345fe0
to
b2b8cf9
Compare
VenelinMartinov
force-pushed
the
vvm/refactor_sdkv2_non_set_detailed_diff_tests
branch
from
December 12, 2024 15:20
07b28a8
to
c411570
Compare
This was referenced Dec 12, 2024
t0yv0
approved these changes
Dec 12, 2024
VenelinMartinov
force-pushed
the
vvm/sdkv2_detailed_diff_set_replace
branch
from
December 13, 2024 16:33
b2b8cf9
to
d168ffb
Compare
VenelinMartinov
force-pushed
the
vvm/refactor_sdkv2_non_set_detailed_diff_tests
branch
from
December 13, 2024 16:33
c411570
to
047f405
Compare
Base automatically changed from
vvm/sdkv2_detailed_diff_set_replace
to
master
December 13, 2024 17:40
VenelinMartinov
deleted the
vvm/refactor_sdkv2_non_set_detailed_diff_tests
branch
December 13, 2024 17:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactors the rest of the SDKv2 detailed diff tests. Instead of recording them inline, we now run them as cross-tests and record them in separate files along with the name of the test and the input values. This mimics what we did for the PF detailed diff tests in #2592
I've gone through the recordings and believe all of them are correct.