Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDKv2 Detailed Diff tests for list replacements #2735

Merged

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Dec 12, 2024

This adds Detailed Diff tests for the SDKv2 bridge for lists with ForceNew. Some of the tests are skipped because of #2726

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.64%. Comparing base (f94f380) to head (bca1c95).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2735   +/-   ##
=======================================
  Coverage   69.64%   69.64%           
=======================================
  Files         301      301           
  Lines       38726    38726           
=======================================
  Hits        26969    26969           
  Misses      10240    10240           
  Partials     1517     1517           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_non_set_detailed_diff_tests branch from d603038 to 07b28a8 Compare December 12, 2024 12:39
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_detailed_diff_list_replacements branch from c9b0de6 to b96946f Compare December 12, 2024 12:39
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_non_set_detailed_diff_tests branch from 07b28a8 to c411570 Compare December 12, 2024 15:20
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_detailed_diff_list_replacements branch from b96946f to 1c99e00 Compare December 12, 2024 15:20
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_non_set_detailed_diff_tests branch from c411570 to 047f405 Compare December 13, 2024 16:33
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_detailed_diff_list_replacements branch from 1c99e00 to 5d5e3d0 Compare December 13, 2024 16:33
Base automatically changed from vvm/refactor_sdkv2_non_set_detailed_diff_tests to master December 13, 2024 17:41
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_detailed_diff_list_replacements branch from 5d5e3d0 to bca1c95 Compare December 13, 2024 17:42
@VenelinMartinov VenelinMartinov enabled auto-merge (squash) December 13, 2024 17:42
@VenelinMartinov VenelinMartinov merged commit 82a4eec into master Dec 13, 2024
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/refactor_sdkv2_detailed_diff_list_replacements branch December 13, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants