Taztingo/1275 remove legacy amino #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
January 12, 2023 14:35
…ule should be updated next since it uses stuff from the name module.
…o update module.go to register the sdk.Msgs.
…nos for ModuleCdc.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1304 +/- ##
==========================================
+ Coverage 58.69% 59.08% +0.39%
==========================================
Files 206 196 -10
Lines 25529 24497 -1032
==========================================
- Hits 14984 14475 -509
+ Misses 9434 8945 -489
+ Partials 1111 1077 -34
|
llama-del-rey
previously approved these changes
Jan 13, 2023
nullpointer0x00
requested changes
Jan 18, 2023
nullpointer0x00
previously approved these changes
Jan 18, 2023
nullpointer0x00
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update ModuleCdc for each module to use ProtoCodec instead of LegacyAminos. Removed LegacyAmino paths from each module and removed querier.go. Removed old migrations since they used legacy aminos. Also removed the unused methods that were needed by the sdk.LegacyMsg.
closes: #1275
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes