Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated legacy amino #1275

Closed
4 tasks
Taztingo opened this issue Dec 20, 2022 · 0 comments · Fixed by #1304
Closed
4 tasks

Remove deprecated legacy amino #1275

Taztingo opened this issue Dec 20, 2022 · 0 comments · Fixed by #1304
Assignees
@Taztingo
Milestone
v1.14.0

Comments

@Taztingo
Copy link
Contributor

Summary

LegacyAmino has been deprecated so we should investigate if it can safely be removed from all our modules. Some of the legacy tests invoke legacy code from other modules so it is probably best to sweep it from all modules.

Problem Definition

This is old deprecated code and causes confusion plus code bloat.

Proposal

Remove LegacyAmino from each of our modules.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Taztingo Taztingo

Labels
None yet
Projects
Provenance Core Protocol Team
Archived in project
Milestone
v1.14.0
1 participant
@Taztingo