Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments reversed between GetSingers and GetSignerBytes in multiple modules #1294

Closed
egaxhaj opened this issue Jan 10, 2023 · 1 comment
Closed

Comments reversed between GetSingers and GetSignerBytes in multiple modules #1294

egaxhaj opened this issue Jan 10, 2023 · 1 comment
Assignees
@egaxhaj
Labels
documentation Improvements or additions to documentation go Pull requests that update Go code
Milestone
v1.14.0

Comments

@egaxhaj
Copy link
Contributor

egaxhaj commented Jan 10, 2023 

    This comment looks to be reversed with the comment on `GetSignerBytes` method in `ln:89`.

// GetSigners indicates that the message must have been signed by the address provided

Originally posted by @egaxhaj in #1285 (comment)
@egaxhaj egaxhaj self-assigned this Jan 10, 2023
@egaxhaj egaxhaj added this to the v1.14.0 milestone Jan 10, 2023
@egaxhaj egaxhaj added documentation Improvements or additions to documentation go Pull requests that update Go code labels Jan 10, 2023
@egaxhaj egaxhaj changed the title This comment looks to be reversed with the comment on GetSignerBytes method in ln:89. Comments reversed between GetSingers and GetSignerBytes in multiple modules Jan 10, 2023
@SpicyLemon
Copy link
Contributor

The GetSignerBytes funcs were all removed with #1304. They're part of the LegacyMsg interface, but not the Msg interface; they're not needed anymore.

So I'm pretty sure it's safe to close this. Feel free to reopen if there's more to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egaxhaj egaxhaj

Labels
documentation Improvements or additions to documentation go Pull requests that update Go code
Projects
Provenance Core Protocol Team
Archived in project
Milestone
v1.14.0
Development

No branches or pull requests
2 participants
@SpicyLemon @egaxhaj