Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taztingo/1275 remove legacy amino #1304

Merged
merged 23 commits into from
Jan 19, 2023
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
af19e3f
Some initial legacy amino removal from name module. The attribute mod…
Dec 20, 2022
091dc40
Finished updating name module. Had to revert a lot of my previous cha…
Jan 5, 2023
9182883
Started work on attribute, but tests aren't passing.
Jan 5, 2023
e984e67
Fixed codec type uses for attribute tests, and now all tests are pass…
Jan 9, 2023
746d630
Removed legacy amino and updated tests for rewards module. Also had t…
Jan 10, 2023
eab5785
Started removing legacy aminos from marker module.
Jan 10, 2023
1fda62e
Finished removing legacy amino from marker.
Jan 10, 2023
d09e3f7
Removed unneeded methods that belonged to LegacyMsg interface.
Jan 10, 2023
7710f6a
Removed legacy amino from metadata and got tests to pass.
Jan 10, 2023
4a3e2e4
Updated name and attribute to use the ProtoCodec instead of LegacyAmi…
Jan 10, 2023
fe0f417
Removed legacy codec from metadata tests.
Jan 10, 2023
786ad74
Updated ModuleCdc for marker to be proto codec.
Jan 10, 2023
8fad782
Added missing bracket from merge.
Jan 10, 2023
cc5239a
Linted name module.
Jan 10, 2023
54584ba
Updated CHANGELOG with link to issue.
Jan 10, 2023
a1ed6e2
Merge branch 'main' into taztingo/1275-remove-legacy-amino
Jan 17, 2023
c3806a1
Removed Type from attributes module.
Jan 18, 2023
d73c680
Removed Type from marker module.
Jan 18, 2023
851dfac
Removed Type from metadata module.
Jan 18, 2023
8ec6f2a
Removed Type from msgfees module.
Jan 18, 2023
ee832a6
Removed Type from name module.
Jan 18, 2023
55c624c
Removed Type from reward module.
Jan 18, 2023
69b341d
Merged in main.
Jan 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* Add basis points field to MsgAssessCustomMsgFeeRequest for split of fee between Fee Module and Recipient [#1268](https://github.com/provenance-io/provenance/issues/1268).
* Updated ibc-go to v6.1 [#1273](https://github.com/provenance-io/provenance/issues/1273).
* Update adding of marker to do additional checks for ibc denoms [#1289](https://github.com/provenance-io/provenance/issues/1289).
* Removed legacy-amino [#1275] (https://github.com/provenance-io/provenance/issues/1275).
---

## [v1.13.0](https://github.com/provenance-io/provenance/releases/tag/v1.13.0) - 2022-11-28
Expand Down
2 changes: 1 addition & 1 deletion internal/handlers/msg_service_router_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1014,7 +1014,7 @@ func TestRewardsProgramStart(t *testing.T) {
NewEvent(rewardtypes.EventTypeRewardProgramCreated,
NewAttribute(rewardtypes.AttributeKeyRewardProgramID, "1")),
NewEvent(sdk.EventTypeMessage,
NewAttribute(sdk.AttributeKeyAction, rewardtypes.TypeMsgCreateRewardProgramRequest)),
NewAttribute(sdk.AttributeKeyAction, sdk.MsgTypeURL(&rewardtypes.MsgCreateRewardProgramRequest{}))),
nullpointer0x00 marked this conversation as resolved.
Show resolved Hide resolved
}
assertEventsContains(t, res.Events, expEvents)
}
Expand Down
14 changes: 0 additions & 14 deletions x/attribute/keeper/migrations.go
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
package keeper

import (
sdk "github.com/cosmos/cosmos-sdk/types"

v042 "github.com/provenance-io/provenance/x/attribute/legacy/v042"
)

// Migrator is a struct for handling in-place store migrations.
type Migrator struct {
keeper Keeper
Expand All @@ -15,11 +9,3 @@ type Migrator struct {
func NewMigrator(keeper Keeper) Migrator {
return Migrator{keeper: keeper}
}

// Migrate1to2 migrates from version 1 to 2 to convert attribute keys from 20 to 32 length
func (m *Migrator) Migrate1to2(ctx sdk.Context) error {
ctx.Logger().Info("Migrating Attribute Module from Version 1 to 2 (1/1)")
err := v042.MigrateAddressLength(ctx, m.keeper.storeKey)
ctx.Logger().Info("Finished Migrating Attribute Module from Version 1 to 2")
return err
}
122 changes: 0 additions & 122 deletions x/attribute/keeper/querier.go

This file was deleted.

41 changes: 0 additions & 41 deletions x/attribute/legacy/v042/store.go

This file was deleted.

147 changes: 0 additions & 147 deletions x/attribute/legacy/v042/store_test.go

This file was deleted.

25 changes: 0 additions & 25 deletions x/attribute/legacy/v042/types.go

This file was deleted.

Loading