Support building DeviceLayer library for EFR32 #125

sagar-apple · 2020-03-26T18:51:19Z

Problem

Code for EFR32 Device Layer does not build.

Summary of Changes

Used the Silicon Labs Gecko SDK to try and get EFR32 DeviceLayer.a to build.
Ignored or disabled unsupported settings (like Thread) for now.
Fixedup code to get the Device Layer to build with the board's SDK.

Pending: Need to file issues for the following things disabled or worked around in this PR.

- Removed: FabricState
- Not Built: EFR32/ThreadStackManagerImpl.cpp
- Disabled: CHIP_DEVICE_CONFIG_ENABLE_THREAD 0 and CHIP_DEVICE_CONFIG_ENABLE_THREAD_TELEMETRY
- Disabled: CHIP_DEVICE_CONFIG_ENABLE_CHIP_TIME_SERVICE_TIME_SYNC
- Removed: Includes from ConnectivityManagerImpl
- Not Built: Entropy.cpp
- Not Built: SoftwareUpdateManagerImpl.cpp
- Removed: SEGGER without OpenThread (Is OpenThread needed)
- Removed: mbedtls was removed from efr32-app.mk
- Removed: linking with freertos
- Removed: linking with warm
- Removed: linking with mincrypt
- Removed: linking with uECC
- Removed: references to linker scripts

fixes #83

gerickson · 2020-03-26T21:07:37Z

Makefile-Standalone

@@ -184,7 +184,7 @@ else
 configure_OPTIONS              +=
 endif

-# If the user has woble over bluez peripheral, alter the configuration options
+# If the user has chipoble over bluez peripheral, alter the configuration options


Should probably be CHIPoBLE for consistency elsewhere.

I was trying to stick to the case format from the original instances. As you'll see elsewhere, it follows woble. "woble" -> "chipoble", "WoBle" -> "CHIPoBLE" and so on.
Should I not do that?

Probably fine for now to stick with what was there. It's a low priority clean-up to make it consistent—at least in comments—later.

gerickson · 2020-03-26T21:08:34Z

configure.ac

@@ -825,7 +825,7 @@ if test "${enable_chipoble_test}" = "yes"; then
 else
    CHIP_ENABLE_BTP_CODEC_TEST=0
 fi
-AC_DEFINE_UNQUOTED([CHIP_ENABLE_BTP_CODEC_TEST],[${CHIP_ENABLE_BTP_CODEC_TEST}],[Define to 1 if you want to enable WoBle Control Path and Throughput Test.])
+AC_DEFINE_UNQUOTED([CHIP_ENABLE_BTP_CODEC_TEST],[${CHIP_ENABLE_BTP_CODEC_TEST}],[Define to 1 if you want to enable CHIPoBle Control Path and Throughput Test.])


See comment above "CHIPoBLE" vs. "chipoble" vs. "CHIPoBle".

configure.ac

gerickson · 2020-03-26T21:12:42Z

src/include/platform/EFR32/gatt.xml

-    <!--WoBLEChar_Rx-->
-    <characteristic id="WoBLEChar_Rx" name="WoBLEChar_Rx" sourceId="custom.type" uuid="18EE2EF5-263D-4559-959F-4F9C429F9D11">
+    <!--CHIPoBLEChar_Rx-->
+    <characteristic id="CHIPoBLEChar_Rx" name="CHIPoBLEChar_Rx" sourceId="custom.type" uuid="18EE2EF5-263D-4559-959F-4F9C429F9D11">


We should probably create a Github issue to create new, CHIP-specific UUIDs for the Rx/Tx characteristics. Otherwise, these will conflict with WoBLE and things may get confusing in the field.

I'll file an issue for this. Thanks!

This is super important actually.

Merge in WMN_TOOLS/matter from v0.4.0_doc_update to silabs Squashed commit of the following: commit 86ee80df8f4fd45e1b651da721e8ed41306e22f4 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 11:42:39 2022 -0400 closing out the rest of Catherine's comments commit 07e8b9c42662d3251da667ae95df74678f8098d7 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 09:58:02 2022 -0400 Chip-Tool -> chip-tool commit ce0b943a13143873572e67afe16c01150d883f9d Author: Ezra Hale <[email protected]> Date: Tue Sep 27 12:18:33 2022 -0400 updated to address Mathieu's issues in the PR ... and 12 more commits

Merge in WMN_TOOLS/matter from cherry-pick/documentation_update to silabs_1.0 Squashed commit of the following: commit c4da7f93ab80339e39ccab65414d4209f2066ec2 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 15:52:04 2022 +0000 Pull request #125: V0.4.0 doc update Merge in WMN_TOOLS/matter from v0.4.0_doc_update to silabs Squashed commit of the following: commit 86ee80df8f4fd45e1b651da721e8ed41306e22f4 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 11:42:39 2022 -0400 closing out the rest of Catherine's comments commit 07e8b9c42662d3251da667ae95df74678f8098d7 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 09:58:02 2022 -0400 Chip-Tool -> chip-tool commit ce0b943a13143873572e67afe16c01150d883f9d Author: Ezra Hale <[email protected]> Date: Tue Sep 27 12:18:33 2022 -0400 updated to address Mathieu's issues in the PR ... and 12 more commits

Merge in WMN_TOOLS/matter from cherry-pick/documentation_update to silabs_1.0 Squashed commit of the following: commit c4da7f93ab80339e39ccab65414d4209f2066ec2 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 15:52:04 2022 +0000 Pull request project-chip#125: V0.4.0 doc update Merge in WMN_TOOLS/matter from v0.4.0_doc_update to silabs Squashed commit of the following: commit 86ee80df8f4fd45e1b651da721e8ed41306e22f4 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 11:42:39 2022 -0400 closing out the rest of Catherine's comments commit 07e8b9c42662d3251da667ae95df74678f8098d7 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 09:58:02 2022 -0400 Chip-Tool -> chip-tool commit ce0b943a13143873572e67afe16c01150d883f9d Author: Ezra Hale <[email protected]> Date: Tue Sep 27 12:18:33 2022 -0400 updated to address Mathieu's issues in the PR ... and 12 more commits

Merge in WMN_TOOLS/matter from v0.4.0_doc_update to silabs Squashed commit of the following: commit 86ee80df8f4fd45e1b651da721e8ed41306e22f4 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 11:42:39 2022 -0400 closing out the rest of Catherine's comments commit 07e8b9c42662d3251da667ae95df74678f8098d7 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 09:58:02 2022 -0400 Chip-Tool -> chip-tool commit ce0b943a13143873572e67afe16c01150d883f9d Author: Ezra Hale <[email protected]> Date: Tue Sep 27 12:18:33 2022 -0400 updated to address Mathieu's issues in the PR ... and 12 more commits

Merge in WMN_TOOLS/matter from cherry-pick/documentation_update to silabs_1.0 Squashed commit of the following: commit c4da7f93ab80339e39ccab65414d4209f2066ec2 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 15:52:04 2022 +0000 Pull request #125: V0.4.0 doc update Merge in WMN_TOOLS/matter from v0.4.0_doc_update to silabs Squashed commit of the following: commit 86ee80df8f4fd45e1b651da721e8ed41306e22f4 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 11:42:39 2022 -0400 closing out the rest of Catherine's comments commit 07e8b9c42662d3251da667ae95df74678f8098d7 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 09:58:02 2022 -0400 Chip-Tool -> chip-tool commit ce0b943a13143873572e67afe16c01150d883f9d Author: Ezra Hale <[email protected]> Date: Tue Sep 27 12:18:33 2022 -0400 updated to address Mathieu's issues in the PR ... and 12 more commits

Merge in WMN_TOOLS/matter from v0.4.0_doc_update to silabs Squashed commit of the following: commit 86ee80df8f4fd45e1b651da721e8ed41306e22f4 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 11:42:39 2022 -0400 closing out the rest of Catherine's comments commit 07e8b9c42662d3251da667ae95df74678f8098d7 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 09:58:02 2022 -0400 Chip-Tool -> chip-tool commit ce0b943a13143873572e67afe16c01150d883f9d Author: Ezra Hale <[email protected]> Date: Tue Sep 27 12:18:33 2022 -0400 updated to address Mathieu's issues in the PR ... and 12 more commits

modifications in logs for step 1, 3, 5 as verification step document changes issue project-chip#125

* chore(TC-DESC-2.1): modified step 1b comments as per verification step document * chore(TL-LTIME-3.1): updated step 9 command and log as verification step modifications as per verfication step document issue #122 * chore(TC-CNET-4.22): modifications for steps 1, 3, 5 modifications in logs for step 1, 3, 5 as verification step document changes issue #125 * chore(TC-DRLK-2.1): modification for step 13a PICS modification for step 13a (From DRLK.S.F0b && DRLK.S.A0015 to DRLK.S.F0b && DRLK.S.A0016) as per test plan changes issue #128 * chore(TC-LCFG-2.1):modifications for PICS step 1a,3 In step 1a and 3 supportedLocales attribute PICS has to be updated LCFG.S.A0001 instead LCFG.S.A0000 as per test plan issue #129 * chore(TC-APPLAUNCHER-3.x.1): modify commands TC-APPLAUNCHER-3.7.1, TC-APPLAUNCHER-3.8.1 and TCAPPLAUNCHER-3.9.1 was updated as per verification step document (DUT as Client) issue #139 * Updates Test_TC_LWM_1_1.yaml * Updates Test_TC_TCCM_1_1.yaml * Updates Test_TC_LWM_1_1.yaml * Updates Test_TC_DISHM_1_1.yaml * Updates Test_TC_DISHM_3_1.yaml * Updates Test_TC_DISHM_3_3.yaml * chore(TC-CONTENTLAUNCHER-10.4): update command and logs command and logs has been updated as per verification step document for all steps * chore(TC-CONTENTLAUNCHER-10.6):update command command has been updated as per verification step document * Updates Test_TC_ICDM_3_4.yaml * chore(TC-ALOGIN-12.2): update command in precondition command has been updated in precondition as per verification step document * Updates Test_TC_CNET_4_9.yaml * Updates Test_TC_CNET_4_10.yaml * Updates Test_TC_CNET_4_11.yaml * Adds NetworkIndex to response in CNET TCs (4.9, 4.10, 4.11) * Updates Test_TC_TCCM_3_1.yaml * Updates Test_TC_TCCM_3_3.yaml * Updates Test_TC_LWM_3_1.yaml * Updates Test_TC_LWM_3_3.yaml * Updates Test_TC_OTCCM_1_1.yaml * Updates Test_TC_OTCCM_2_1.yaml * Updates Test_TC_S_3_1.yaml * Restores TC-LWM-1.1 * Restores TC-TCCM-1.1 * Fix yaml formatting * Fix restyle * Fix restyle * Fix restyle * Removes (DEPONOFF) from pics ref --------- Co-authored-by: raul-marquez-csa <[email protected]> Co-authored-by: Raul Marquez <[email protected]>

Merge in WMN_TOOLS/matter from v0.4.0_doc_update to silabs Squashed commit of the following: commit 86ee80df8f4fd45e1b651da721e8ed41306e22f4 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 11:42:39 2022 -0400 closing out the rest of Catherine's comments commit 07e8b9c42662d3251da667ae95df74678f8098d7 Author: Ezra Hale <[email protected]> Date: Tue Oct 4 09:58:02 2022 -0400 Chip-Tool -> chip-tool commit ce0b943a13143873572e67afe16c01150d883f9d Author: Ezra Hale <[email protected]> Date: Tue Sep 27 12:18:33 2022 -0400 updated to address Mathieu's issues in the PR ... and 12 more commits

* [SL-UP] Bugfix/silabs out rtt removal (#142) * [SL-UP] Bugfix/matter shell crash nullptr (#125) * Added checks on null ptr to prevent uart shell crash and modified ICD shell commands to be compatible with our internal structure

* [SL-UP] Bugfix/silabs out rtt removal (project-chip#142) * [SL-UP] Bugfix/matter shell crash nullptr (project-chip#125) * Added checks on null ptr to prevent uart shell crash and modified ICD shell commands to be compatible with our internal structure

sagar-apple added 2 commits March 26, 2020 11:25

Make DeviceLayer compile for EFR32

0dbc5ca

Fix nRF5 builds as well

38cd9ff

sagar-apple requested a review from pan-apple March 26, 2020 18:51

sagar-apple requested review from anush-apple, BroderickCarlin, chrisdecenzo, gerickson, hawk248, robszewczyk, tpmanley and woody-apple as code owners March 26, 2020 18:51

sagar-apple changed the title ~~Make build efr32~~ Support building DeviceLayer library for EFR32 Mar 26, 2020

woody-apple approved these changes Mar 26, 2020

View reviewed changes

BroderickCarlin approved these changes Mar 26, 2020

View reviewed changes

gerickson reviewed Mar 26, 2020

View reviewed changes

gerickson suggested changes Mar 26, 2020

View reviewed changes

Remove accidental change

e96c67c

gerickson approved these changes Mar 26, 2020

View reviewed changes

woody-apple merged commit ca9dfc2 into project-chip:master Mar 26, 2020

sagar-apple deleted the make_build_efr32 branch March 26, 2020 22:01

sagar-apple mentioned this pull request Mar 26, 2020

Not all EFR32 platform source files are being built #134

Closed

pan-apple mentioned this pull request Mar 26, 2020

BLE Device name is hardcoded #112

Closed

sagar-apple mentioned this pull request Mar 26, 2020

TimeSync Service is not supported on EFR32 #137

Closed

pan-apple mentioned this pull request Mar 26, 2020

Reenable TIME_SERVICE_TIME_SYNC #105

Closed

This was referenced Mar 26, 2020

Fix EFR32 Build Support file dependencies #138

Closed

Fix OpenThread Dependencies for EFR32 #139

Closed

gvargas-csa added a commit to gvargas-csa/connectedhomeip that referenced this pull request Feb 14, 2024

chore(TC-CNET-4.22): modifications for steps 1, 3, 5

9240ae7

modifications in logs for step 1, 3, 5 as verification step document changes issue project-chip#125

lpbeliveau-silabs added a commit to lpbeliveau-silabs/connectedhomeip that referenced this pull request Nov 28, 2024

[SL-UP] Bugfix/matter shell crash nullptr (project-chip#125)

97705e1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support building DeviceLayer library for EFR32 #125

Support building DeviceLayer library for EFR32 #125

sagar-apple commented Mar 26, 2020

gerickson Mar 26, 2020

sagar-apple Mar 26, 2020

gerickson Mar 26, 2020

gerickson Mar 26, 2020

gerickson Mar 26, 2020

sagar-apple Mar 26, 2020

sagar-apple Mar 26, 2020

Support building DeviceLayer library for EFR32 #125

Support building DeviceLayer library for EFR32 #125

Conversation

sagar-apple commented Mar 26, 2020

Problem

Summary of Changes

gerickson Mar 26, 2020

Choose a reason for hiding this comment

sagar-apple Mar 26, 2020

Choose a reason for hiding this comment

gerickson Mar 26, 2020

Choose a reason for hiding this comment

gerickson Mar 26, 2020

Choose a reason for hiding this comment

gerickson Mar 26, 2020

Choose a reason for hiding this comment

sagar-apple Mar 26, 2020

Choose a reason for hiding this comment

sagar-apple Mar 26, 2020

Choose a reason for hiding this comment