Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base45 to a Set up payload #164

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Base45 to a Set up payload #164

merged 2 commits into from
Mar 31, 2020

Conversation

bhaskar-apple
Copy link
Contributor

Problem

We need to implement a base45 to a SetupPayload converter

Summary of Changes

Adds a new class QRCodeSetupPayloadParser to convert a base45 string to SetupPayload

fixes Base45 to a Set up payload #146

bhaskar-apple
bhaskar-apple commented Mar 31, 2020
View reviewed changes
src/setup_payload/tests/tests_qrcode.cpp
@@ -29,7 +29,8 @@
using namespace chip;
using namespace std;

#define EXPECT_EQ(x, y) ((x) != (y)) ? cerr << __FILE__ << ":" << __LINE__ << ":error EXPECT_EQ(" << x << ", " << y << ")\n", 1 : 0
#define EXPECT_EQ(x, y) \
((x) != (y)) ? cerr << endl << __FILE__ << ":" << __LINE__ << ":error EXPECT_EQ(" << x << ", " << y << ")\n", 1 : 0
Copy link
Contributor Author

@bhaskar-apple bhaskar-apple Mar 31, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify this change. Just added a endlto make it easy to read the logged output

hawk248
hawk248 approved these changes Mar 31, 2020
View reviewed changes
Copy link

@hawk248 hawk248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@woody-apple woody-apple merged commit b19f044 into project-chip:master Mar 31, 2020
@bhaskar-apple bhaskar-apple deleted the BS-QRCodeParser branch April 10, 2020 05:33
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Oct 13, 2022
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#164: Cherry-Pick V0.4.0 doc update
8228315 
Merge in WMN_TOOLS/matter from cherry-pick/documentation_update to silabs_1.0

Squashed commit of the following:

commit c4da7f93ab80339e39ccab65414d4209f2066ec2
Author: Ezra Hale <[email protected]>
Date:   Tue Oct 4 15:52:04 2022 +0000

    Pull request #125: V0.4.0 doc update

    Merge in WMN_TOOLS/matter from v0.4.0_doc_update to silabs

    Squashed commit of the following:

    commit 86ee80df8f4fd45e1b651da721e8ed41306e22f4
    Author: Ezra Hale <[email protected]>
    Date:   Tue Oct 4 11:42:39 2022 -0400

        closing out the rest of Catherine's comments

    commit 07e8b9c42662d3251da667ae95df74678f8098d7
    Author: Ezra Hale <[email protected]>
    Date:   Tue Oct 4 09:58:02 2022 -0400

        Chip-Tool -> chip-tool

    commit ce0b943a13143873572e67afe16c01150d883f9d
    Author: Ezra Hale <[email protected]>
    Date:   Tue Sep 27 12:18:33 2022 -0400

        updated to address Mathieu's issues in the PR

    ... and 12 more commits
nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this pull request Oct 19, 2022
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#164: Cherry-Pick V0.4.0 doc update
048ae01 
Merge in WMN_TOOLS/matter from cherry-pick/documentation_update to silabs_1.0

Squashed commit of the following:

commit c4da7f93ab80339e39ccab65414d4209f2066ec2
Author: Ezra Hale <[email protected]>
Date:   Tue Oct 4 15:52:04 2022 +0000

    Pull request project-chip#125: V0.4.0 doc update

    Merge in WMN_TOOLS/matter from v0.4.0_doc_update to silabs

    Squashed commit of the following:

    commit 86ee80df8f4fd45e1b651da721e8ed41306e22f4
    Author: Ezra Hale <[email protected]>
    Date:   Tue Oct 4 11:42:39 2022 -0400

        closing out the rest of Catherine's comments

    commit 07e8b9c42662d3251da667ae95df74678f8098d7
    Author: Ezra Hale <[email protected]>
    Date:   Tue Oct 4 09:58:02 2022 -0400

        Chip-Tool -> chip-tool

    commit ce0b943a13143873572e67afe16c01150d883f9d
    Author: Ezra Hale <[email protected]>
    Date:   Tue Sep 27 12:18:33 2022 -0400

        updated to address Mathieu's issues in the PR

    ... and 12 more commits
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Nov 2, 2022
@mkardous-silabs @jmartinez-silabs
Pull request #164: Cherry-Pick V0.4.0 doc update
be14f97 
Merge in WMN_TOOLS/matter from cherry-pick/documentation_update to silabs_1.0

Squashed commit of the following:

commit c4da7f93ab80339e39ccab65414d4209f2066ec2
Author: Ezra Hale <[email protected]>
Date:   Tue Oct 4 15:52:04 2022 +0000

    Pull request #125: V0.4.0 doc update

    Merge in WMN_TOOLS/matter from v0.4.0_doc_update to silabs

    Squashed commit of the following:

    commit 86ee80df8f4fd45e1b651da721e8ed41306e22f4
    Author: Ezra Hale <[email protected]>
    Date:   Tue Oct 4 11:42:39 2022 -0400

        closing out the rest of Catherine's comments

    commit 07e8b9c42662d3251da667ae95df74678f8098d7
    Author: Ezra Hale <[email protected]>
    Date:   Tue Oct 4 09:58:02 2022 -0400

        Chip-Tool -> chip-tool

    commit ce0b943a13143873572e67afe16c01150d883f9d
    Author: Ezra Hale <[email protected]>
    Date:   Tue Sep 27 12:18:33 2022 -0400

        updated to address Mathieu's issues in the PR

    ... and 12 more commits
rerasool pushed a commit to SiliconLabs/matter that referenced this pull request Nov 2, 2022
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#164: Cherry-Pick V0.4.0 doc update
6e8f8ba 
Merge in WMN_TOOLS/matter from cherry-pick/documentation_update to silabs_1.0

Squashed commit of the following:

commit c4da7f93ab80339e39ccab65414d4209f2066ec2
Author: Ezra Hale <[email protected]>
Date:   Tue Oct 4 15:52:04 2022 +0000

    Pull request #125: V0.4.0 doc update

    Merge in WMN_TOOLS/matter from v0.4.0_doc_update to silabs

    Squashed commit of the following:

    commit 86ee80df8f4fd45e1b651da721e8ed41306e22f4
    Author: Ezra Hale <[email protected]>
    Date:   Tue Oct 4 11:42:39 2022 -0400

        closing out the rest of Catherine's comments

    commit 07e8b9c42662d3251da667ae95df74678f8098d7
    Author: Ezra Hale <[email protected]>
    Date:   Tue Oct 4 09:58:02 2022 -0400

        Chip-Tool -> chip-tool

    commit ce0b943a13143873572e67afe16c01150d883f9d
    Author: Ezra Hale <[email protected]>
    Date:   Tue Sep 27 12:18:33 2022 -0400

        updated to address Mathieu's issues in the PR

    ... and 12 more commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwalker-apple rwalker-apple rwalker-apple left review comments

@sagar-apple sagar-apple sagar-apple left review comments

@woody-apple woody-apple woody-apple approved these changes

@hawk248 hawk248 hawk248 approved these changes

@gerickson gerickson gerickson approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@tpmanley tpmanley Awaiting requested review from tpmanley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bhaskar-apple @gerickson @hawk248 @woody-apple @sagar-apple @rwalker-apple @Bhaskar-Sarma