Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE Device name is hardcoded #112

Closed
pan-apple opened this issue Mar 25, 2020 · 0 comments · Fixed by #18006
Closed

BLE Device name is hardcoded #112

pan-apple opened this issue Mar 25, 2020 · 0 comments · Fixed by #18006

Comments

@pan-apple
Copy link
Contributor

pan-apple commented Mar 25, 2020

Problem

BLEManagerImpl.cpp computes device name using FabricState.LocalNodeId(). This was removed (and hardcoded to 0) in #104 for nRF5 and in #125 for EFR32.

Proposed Solution

Identify the correct replacement for LocalNodeId and use that to compute device name.

Code reference:
nRF5 -

snprintf(devNameBuf, sizeof(devNameBuf), "%s%04" PRIX32,
CHIP_DEVICE_CONFIG_BLE_DEVICE_NAME_PREFIX,
(uint32_t)0);

EFR32 -
snprintf(mDeviceName, sizeof(mDeviceName), "%s%04" PRIX32, CHIP_DEVICE_CONFIG_BLE_DEVICE_NAME_PREFIX,
(uint32_t)0);

@rwalker-apple rwalker-apple added this to the M3 milestone Mar 25, 2020
@woody-apple woody-apple added V1.0 and removed V0.7 labels Jan 25, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 3, 2022
These had hardcoded 0, while other platforms use the discriminator.

Fixes project-chip#112
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 3, 2022
These had hardcoded 0, while other platforms use the discriminator.

Fixes project-chip#112
bzbarsky-apple added a commit that referenced this issue May 4, 2022
…18006)

These had hardcoded 0, while other platforms use the discriminator.

Fixes #112
yufengwangca pushed a commit that referenced this issue Mar 16, 2023
…ged (#25665)

* tv-casting-app: Allow for a way for Matter TV casting cache to be purged (#112)

* tv-casting-app: Adding a way to purge cached video players

* Android tv-casting-app: Adding purge cache button

* iOS tv-casting-app: Adding purge cache button

* Addressing feedback from Cliff
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
…ged (project-chip#25665)

* tv-casting-app: Allow for a way for Matter TV casting cache to be purged (project-chip#112)

* tv-casting-app: Adding a way to purge cached video players

* Android tv-casting-app: Adding purge cache button

* iOS tv-casting-app: Adding purge cache button

* Addressing feedback from Cliff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants