-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLE Device name is hardcoded #112
Labels
Milestone
Comments
andy31415
added
v1_triage_split_11
feature work
ble
V1.0
and removed
feature work
ble
V1.0
labels
Jan 30, 2022
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
May 3, 2022
These had hardcoded 0, while other platforms use the discriminator. Fixes project-chip#112
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
May 3, 2022
These had hardcoded 0, while other platforms use the discriminator. Fixes project-chip#112
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this issue
Mar 22, 2023
…ged (project-chip#25665) * tv-casting-app: Allow for a way for Matter TV casting cache to be purged (project-chip#112) * tv-casting-app: Adding a way to purge cached video players * Android tv-casting-app: Adding purge cache button * iOS tv-casting-app: Adding purge cache button * Addressing feedback from Cliff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
BLEManagerImpl.cpp
computes device name usingFabricState.LocalNodeId()
. This was removed (and hardcoded to 0) in #104 for nRF5 and in #125 for EFR32.Proposed Solution
Identify the correct replacement for
LocalNodeId
and use that to compute device name.Code reference:
nRF5 -
connectedhomeip/src/platform/nRF5/BLEManagerImpl.cpp
Lines 251 to 253 in ca9dfc2
EFR32 -
connectedhomeip/src/platform/EFR32/BLEManagerImpl.cpp
Lines 584 to 585 in ca9dfc2
The text was updated successfully, but these errors were encountered: