Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tv-casting-app: Allow for a way for Matter TV casting cache to be purged #25665

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

sharadb-amazon
Copy link
Contributor

Fixes #25664

Problem

The Android/iOS/Linux tv-casting-apps currently do not have a way to delete the list of cached video players. Allowing this can be useful, in cases where, say a user may want their video players list deleted (for privacy) before signing out of the casting apps. If there is no way to do this, we run the risk of allowing a user-b to establish CASE with a video player user-a commissioned with, if both users are using the same tv-casting-app instance.

Change summary

  1. Added APIs for Android/iOS/Linux to purgeCache
  2. Added GUI buttons on Android/iOS to call this API

Testing

Tested with the Android/iOS tv-casting-apps and checked that the list of video players is deleted.

…ged (#112)

* tv-casting-app: Adding a way to purge cached video players

* Android tv-casting-app: Adding purge cache button

* iOS tv-casting-app: Adding purge cache button
@github-actions
Copy link

PR #25665: Size comparison from d04e396 to 42413d2

Increases (1 build for cc32xx)
platform target config section d04e396 42413d2c change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20245939 20245940 1 0.0
Full report (1 build for cc32xx)
platform target config section d04e396 42413d2c change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245939 20245940 1 0.0
.debug_line 2660971 2660971 0 0.0
.debug_loc 2804896 2804896 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0

@github-actions
Copy link

PR #25665: Size comparison from 82290df to cc752b0

Full report (1 build for cc32xx)
platform target config section 82290df cc752b0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930289 930289 0 0.0
.debug_aranges 87392 87392 0 0.0
.debug_frame 300284 300284 0 0.0
.debug_info 20246023 20246023 0 0.0
.debug_line 2661031 2661031 0 0.0
.debug_loc 2804874 2804874 0 0.0
.debug_ranges 283152 283152 0 0.0
.debug_str 3027037 3027037 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380331 380331 0 0.0
.symtab 257376 257376 0 0.0
.text 537376 537376 0 0.0

@yufengwangca yufengwangca merged commit 00a6fcf into project-chip:master Mar 16, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
…ged (project-chip#25665)

* tv-casting-app: Allow for a way for Matter TV casting cache to be purged (project-chip#112)

* tv-casting-app: Adding a way to purge cached video players

* Android tv-casting-app: Adding purge cache button

* iOS tv-casting-app: Adding purge cache button

* Addressing feedback from Cliff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] tv-casting-app: Allow for a way for Matter TV casting cache to be purged
4 participants