-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tv-casting-app: Allow for a way for Matter TV casting cache to be purged #25665
Merged
yufengwangca
merged 2 commits into
project-chip:master
from
sharadb-amazon:purge-20230313
Mar 16, 2023
Merged
tv-casting-app: Allow for a way for Matter TV casting cache to be purged #25665
yufengwangca
merged 2 commits into
project-chip:master
from
sharadb-amazon:purge-20230313
Mar 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged (#112) * tv-casting-app: Adding a way to purge cached video players * Android tv-casting-app: Adding purge cache button * iOS tv-casting-app: Adding purge cache button
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
March 13, 2023 19:41
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
younghak-hwang
March 13, 2023 19:41
PR #25665: Size comparison from d04e396 to 42413d2 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
chrisdecenzo
approved these changes
Mar 13, 2023
cliffamzn
reviewed
Mar 14, 2023
examples/tv-casting-app/android/App/app/src/main/jni/cpp/TvCastingApp-JNI.cpp
Show resolved
Hide resolved
sharadb-amazon
force-pushed
the
purge-20230313
branch
from
March 16, 2023 18:17
e4b2319
to
cc752b0
Compare
PR #25665: Size comparison from 82290df to cc752b0 Full report (1 build for cc32xx)
|
yufengwangca
approved these changes
Mar 16, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ged (project-chip#25665) * tv-casting-app: Allow for a way for Matter TV casting cache to be purged (project-chip#112) * tv-casting-app: Adding a way to purge cached video players * Android tv-casting-app: Adding purge cache button * iOS tv-casting-app: Adding purge cache button * Addressing feedback from Cliff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25664
Problem
The Android/iOS/Linux tv-casting-apps currently do not have a way to delete the list of cached video players. Allowing this can be useful, in cases where, say a user may want their video players list deleted (for privacy) before signing out of the casting apps. If there is no way to do this, we run the risk of allowing a user-b to establish CASE with a video player user-a commissioned with, if both users are using the same tv-casting-app instance.
Change summary
Testing
Tested with the Android/iOS tv-casting-apps and checked that the list of video players is deleted.