-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building DeviceLayer library for EFR32 #125
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -825,7 +825,7 @@ if test "${enable_chipoble_test}" = "yes"; then | |
else | ||
CHIP_ENABLE_BTP_CODEC_TEST=0 | ||
fi | ||
AC_DEFINE_UNQUOTED([CHIP_ENABLE_BTP_CODEC_TEST],[${CHIP_ENABLE_BTP_CODEC_TEST}],[Define to 1 if you want to enable WoBle Control Path and Throughput Test.]) | ||
AC_DEFINE_UNQUOTED([CHIP_ENABLE_BTP_CODEC_TEST],[${CHIP_ENABLE_BTP_CODEC_TEST}],[Define to 1 if you want to enable CHIPoBle Control Path and Throughput Test.]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See comment above "CHIPoBLE" vs. "chipoble" vs. "CHIPoBle". |
||
# | ||
# Documentation | ||
# | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -76,19 +76,19 @@ | |
</characteristic> | ||
</service> | ||
|
||
<!--WoBLE--> | ||
<service advertise="false" name="WoBLE" requirement="mandatory" sourceId="custom.type" type="primary" uuid="feaf"> | ||
<!--CHIPoBLE--> | ||
<service advertise="false" name="CHIPoBLE" requirement="mandatory" sourceId="custom.type" type="primary" uuid="feaf"> | ||
<informativeText>Custom service</informativeText> | ||
|
||
<!--WoBLEChar_Rx--> | ||
<characteristic id="WoBLEChar_Rx" name="WoBLEChar_Rx" sourceId="custom.type" uuid="18EE2EF5-263D-4559-959F-4F9C429F9D11"> | ||
<!--CHIPoBLEChar_Rx--> | ||
<characteristic id="CHIPoBLEChar_Rx" name="CHIPoBLEChar_Rx" sourceId="custom.type" uuid="18EE2EF5-263D-4559-959F-4F9C429F9D11"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should probably create a Github issue to create new, CHIP-specific UUIDs for the Rx/Tx characteristics. Otherwise, these will conflict with WoBLE and things may get confusing in the field. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll file an issue for this. Thanks! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is super important actually. |
||
<informativeText>Custom characteristic</informativeText> | ||
<value length="247" type="hex" variable_length="true">0x00</value> | ||
<properties read="true" read_requirement="optional" write="true" write_requirement="optional"/> | ||
</characteristic> | ||
|
||
<!--WoBLEChar_Tx--> | ||
<characteristic id="WoBLEChar_Tx" name="WoBLEChar_Tx" sourceId="custom.type" uuid="18EE2EF5-263D-4559-959F-4F9C429F9D12"> | ||
<!--CHIPoBLEChar_Tx--> | ||
<characteristic id="CHIPoBLEChar_Tx" name="CHIPoBLEChar_Tx" sourceId="custom.type" uuid="18EE2EF5-263D-4559-959F-4F9C429F9D12"> | ||
<informativeText>Custom characteristic</informativeText> | ||
<value length="247" type="hex" variable_length="true">0x00</value> | ||
<properties indicate="true" indicate_requirement="optional" read="true" read_requirement="optional" write="true" write_no_response="true" write_no_response_requirement="optional" write_requirement="optional"/> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be
CHIPoBLE
for consistency elsewhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to stick to the case format from the original instances. As you'll see elsewhere, it follows woble. "woble" -> "chipoble", "WoBle" -> "CHIPoBLE" and so on.
Should I not do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably fine for now to stick with what was there. It's a low priority clean-up to make it consistent—at least in comments—later.