-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: more audit remediations #470
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaspitz
force-pushed
the
audit-fixes-part2
branch
2 times, most recently
from
November 7, 2024 00:17
85ad935
to
5c71ece
Compare
shaspitz
changed the title
fix: misc lower prio audit remediations
fix: more audit remediations
Nov 7, 2024
shaspitz
force-pushed
the
audit-fixes-part2
branch
from
November 7, 2024 05:11
0df72e7
to
03fd124
Compare
Mikelle
reviewed
Nov 7, 2024
…change in state during func call
shaspitz
force-pushed
the
audit-fixes-part2
branch
from
November 7, 2024 17:42
013cc50
to
7b492ca
Compare
Mikelle
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
More audit fixes! These ones don't necessarily correspond to findings from the official report, as some of them are low/info severity.
Changes:
ValidatorOptInRouter.areValidatorsOptedIn
now returns a struct containing three booleans representing which registries a validator is registered with. This will be useful for oracle slashing logic. Commit: 6d49ffd. This PR includes off-chain updates for this change in api.Gateway.relayer
was added, along w/ missing tests for related setters. Commit: 530add7IEnumerableSet.add
in the middleware contract, and revert if theadd
fails. Note this revert shouldn't happen and would indicate state corruption. Commit: 9c39370wouldVaultBeValidWith
function to the middleware contract, along with documentation. The new function assists the owner account in confirming preconditions prior to callingsetSlashPeriodSeconds
. Commit: 4223760Checklist before requesting a review