Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more audit remediations #470

Merged
merged 17 commits into from
Nov 7, 2024
Merged

fix: more audit remediations #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3cd2084
feat: return multiple booleans from validatorOptInRouter.areValidator…
shaspitz Nov 6, 2024
9dd3f27
fix: issue 3.2.4 from audit report, introduce setRelayer function for…
shaspitz Nov 6, 2024
cf98413
chore: update abi+binding
shaspitz Nov 6, 2024
1b861d8
chore: check return value of IEnumerableSet.add
shaspitz Nov 6, 2024
83b2594
docs: note on frozen validators registering with other contracts
shaspitz Nov 6, 2024
d05eb57
feat: introduce wouldVaultBeValidWith function, along with documentation
shaspitz Nov 6, 2024
d47fe2b
chore: update eigenlayer ref + mocks
shaspitz Nov 6, 2024
6b24d73
chore: appease linter
shaspitz Nov 6, 2024
c25471e
chore: update symbiotic to recent main
shaspitz Nov 6, 2024
4bccbee
fix: off-chain handling of opt-in router changes
shaspitz Nov 7, 2024
ff84d99
fix: TestGetValidators
shaspitz Nov 7, 2024
e9a9d83
fix: TestGetValidators_EpochZero
shaspitz Nov 7, 2024
02d4b6d
refactor: remove any modifiers from MevCommitAVS that could possibly …
shaspitz Nov 7, 2024
715a75e
feat: further simplify symbiotic veto slashing logic
shaspitz Nov 7, 2024
182d519
chore: update go binding
shaspitz Nov 7, 2024
1681ac4
docs: rm todo
shaspitz Nov 7, 2024
7b492ca
use local vars to reduce storage reads in mevcommitavs
shaspitz Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions contracts-abi/abi/L1Gateway.abi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,19 @@
"outputs": [],
"stateMutability": "nonpayable"
},
{
"type": "function",
"name": "setRelayer",
"inputs": [
{
"name": "_relayer",
"type": "address",
"internalType": "address"
}
],
"outputs": [],
"stateMutability": "nonpayable"
},
{
"type": "function",
"name": "transferFinalizedIdx",
Expand Down Expand Up @@ -424,6 +437,19 @@
],
"anonymous": false
},
{
"type": "event",
"name": "RelayerSet",
"inputs": [
{
"name": "relayer",
"type": "address",
"indexed": true,
"internalType": "address"
}
],
"anonymous": false
},
{
"type": "event",
"name": "TransferFinalized",
Expand Down Expand Up @@ -725,6 +751,11 @@
"name": "ReentrancyGuardReentrantCall",
"inputs": []
},
{
"type": "error",
"name": "RelayerCannotBeZeroAddress",
"inputs": []
},
{
"type": "error",
"name": "SenderNotRelayer",
Expand Down
2 changes: 1 addition & 1 deletion contracts-abi/abi/MevCommitAVS.abi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,7 @@
"name": "unfreeze",
"inputs": [
{
"name": "valPubKey",
"name": "valPubKeys",
"type": "bytes[]",
"internalType": "bytes[]"
}
Expand Down
100 changes: 45 additions & 55 deletions contracts-abi/abi/MevCommitMiddleware.abi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,30 +84,6 @@
"outputs": [],
"stateMutability": "nonpayable"
},
{
"type": "function",
"name": "executeSlashes",
"inputs": [
{
"name": "blsPubkeys",
"type": "bytes[]",
"internalType": "bytes[]"
},
{
"name": "slashIndexes",
"type": "uint256[]",
"internalType": "uint256[]"
}
],
"outputs": [
{
"name": "slashedAmounts",
"type": "uint256[]",
"internalType": "uint256[]"
}
],
"stateMutability": "nonpayable"
},
{
"type": "function",
"name": "getLatestSlashAmount",
Expand Down Expand Up @@ -945,6 +921,30 @@
],
"stateMutability": "view"
},
{
"type": "function",
"name": "wouldVaultBeValidWith",
"inputs": [
{
"name": "vault",
"type": "address",
"internalType": "address"
},
{
"name": "potentialSLashPeriodSeconds",
"type": "uint256",
"internalType": "uint256"
}
],
"outputs": [
{
"name": "",
"type": "bool",
"internalType": "bool"
}
],
"stateMutability": "view"
},
{
"type": "event",
"name": "Initialized",
Expand Down Expand Up @@ -1284,37 +1284,6 @@
],
"anonymous": false
},
{
"type": "event",
"name": "ValidatorSlashRequested",
"inputs": [
{
"name": "blsPubkey",
"type": "bytes",
"indexed": false,
"internalType": "bytes"
},
{
"name": "operator",
"type": "address",
"indexed": true,
"internalType": "address"
},
{
"name": "vault",
"type": "address",
"indexed": true,
"internalType": "address"
},
{
"name": "slashIndex",
"type": "uint256",
"indexed": false,
"internalType": "uint256"
}
],
"anonymous": false
},
{
"type": "event",
"name": "ValidatorSlashed",
Expand Down Expand Up @@ -1475,6 +1444,27 @@
"name": "FailedInnerCall",
"inputs": []
},
{
"type": "error",
"name": "FailedToAddValidatorToValset",
"inputs": [
{
"name": "blsPubkey",
"type": "bytes",
"internalType": "bytes"
},
{
"name": "vault",
"type": "address",
"internalType": "address"
},
{
"name": "operator",
"type": "address",
"internalType": "address"
}
]
},
{
"type": "error",
"name": "FullRestakeDelegatorNotSupported",
Expand Down
31 changes: 31 additions & 0 deletions contracts-abi/abi/SettlementGateway.abi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,19 @@
"outputs": [],
"stateMutability": "nonpayable"
},
{
"type": "function",
"name": "setRelayer",
"inputs": [
{
"name": "_relayer",
"type": "address",
"internalType": "address"
}
],
"outputs": [],
"stateMutability": "nonpayable"
},
{
"type": "function",
"name": "transferFinalizedIdx",
Expand Down Expand Up @@ -410,6 +423,19 @@
],
"anonymous": false
},
{
"type": "event",
"name": "RelayerSet",
"inputs": [
{
"name": "relayer",
"type": "address",
"indexed": true,
"internalType": "address"
}
],
"anonymous": false
},
{
"type": "event",
"name": "TransferFinalized",
Expand Down Expand Up @@ -651,6 +677,11 @@
"name": "ReentrancyGuardReentrantCall",
"inputs": []
},
{
"type": "error",
"name": "RelayerCannotBeZeroAddress",
"inputs": []
},
{
"type": "error",
"name": "SenderNotRelayer",
Expand Down
21 changes: 19 additions & 2 deletions contracts-abi/abi/ValidatorOptInRouter.abi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,25 @@
"outputs": [
{
"name": "",
"type": "bool[]",
"internalType": "bool[]"
"type": "tuple[]",
"internalType": "struct IValidatorOptInRouter.OptInStatus[]",
"components": [
{
"name": "isVanillaOptedIn",
"type": "bool",
"internalType": "bool"
},
{
"name": "isAvsOptedIn",
"type": "bool",
"internalType": "bool"
},
{
"name": "isMiddlewareOptedIn",
"type": "bool",
"internalType": "bool"
}
]
}
],
"stateMutability": "view"
Expand Down
167 changes: 166 additions & 1 deletion contracts-abi/clients/L1Gateway/L1Gateway.go
View file
Open in desktop

Large diffs are not rendered by default.

20 changes: 10 additions & 10 deletions contracts-abi/clients/MevCommitAVS/MevCommitAVS.go
View file
Open in desktop

Large diffs are not rendered by default.

209 changes: 32 additions & 177 deletions contracts-abi/clients/MevCommitMiddleware/MevCommitMiddleware.go
View file
Open in desktop

Large diffs are not rendered by default.

167 changes: 166 additions & 1 deletion contracts-abi/clients/SettlementGateway/SettlementGateway.go
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading