fix: more audit remediations (#470)

primev · Nov 7, 2024 · f17e2e5 · f17e2e5
1 parent 5ed4429
commit f17e2e5
Show file tree

Hide file tree

Showing 34 changed files with 859 additions and 548 deletions.
diff --git a/contracts-abi/abi/L1Gateway.abi b/contracts-abi/abi/L1Gateway.abi
@@ -238,6 +238,19 @@
     "outputs": [],
     "stateMutability": "nonpayable"
   },
+  {
+    "type": "function",
+    "name": "setRelayer",
+    "inputs": [
+      {
+        "name": "_relayer",
+        "type": "address",
+        "internalType": "address"
+      }
+    ],
+    "outputs": [],
+    "stateMutability": "nonpayable"
+  },
   {
     "type": "function",
     "name": "transferFinalizedIdx",
@@ -424,6 +437,19 @@
     ],
     "anonymous": false
   },
+  {
+    "type": "event",
+    "name": "RelayerSet",
+    "inputs": [
+      {
+        "name": "relayer",
+        "type": "address",
+        "indexed": true,
+        "internalType": "address"
+      }
+    ],
+    "anonymous": false
+  },
   {
     "type": "event",
     "name": "TransferFinalized",
@@ -725,6 +751,11 @@
     "name": "ReentrancyGuardReentrantCall",
     "inputs": []
   },
+  {
+    "type": "error",
+    "name": "RelayerCannotBeZeroAddress",
+    "inputs": []
+  },
   {
     "type": "error",
     "name": "SenderNotRelayer",

diff --git a/contracts-abi/abi/MevCommitAVS.abi b/contracts-abi/abi/MevCommitAVS.abi
@@ -850,7 +850,7 @@
     "name": "unfreeze",
     "inputs": [
       {
-        "name": "valPubKey",
+        "name": "valPubKeys",
         "type": "bytes[]",
         "internalType": "bytes[]"
       }

diff --git a/contracts-abi/abi/MevCommitMiddleware.abi b/contracts-abi/abi/MevCommitMiddleware.abi
@@ -84,30 +84,6 @@
     "outputs": [],
     "stateMutability": "nonpayable"
   },
-  {
-    "type": "function",
-    "name": "executeSlashes",
-    "inputs": [
-      {
-        "name": "blsPubkeys",
-        "type": "bytes[]",
-        "internalType": "bytes[]"
-      },
-      {
-        "name": "slashIndexes",
-        "type": "uint256[]",
-        "internalType": "uint256[]"
-      }
-    ],
-    "outputs": [
-      {
-        "name": "slashedAmounts",
-        "type": "uint256[]",
-        "internalType": "uint256[]"
-      }
-    ],
-    "stateMutability": "nonpayable"
-  },
   {
     "type": "function",
     "name": "getLatestSlashAmount",
@@ -945,6 +921,30 @@
     ],
     "stateMutability": "view"
   },
+  {
+    "type": "function",
+    "name": "wouldVaultBeValidWith",
+    "inputs": [
+      {
+        "name": "vault",
+        "type": "address",
+        "internalType": "address"
+      },
+      {
+        "name": "potentialSLashPeriodSeconds",
+        "type": "uint256",
+        "internalType": "uint256"
+      }
+    ],
+    "outputs": [
+      {
+        "name": "",
+        "type": "bool",
+        "internalType": "bool"
+      }
+    ],
+    "stateMutability": "view"
+  },
   {
     "type": "event",
     "name": "Initialized",
@@ -1284,37 +1284,6 @@
     ],
     "anonymous": false
   },
-  {
-    "type": "event",
-    "name": "ValidatorSlashRequested",
-    "inputs": [
-      {
-        "name": "blsPubkey",
-        "type": "bytes",
-        "indexed": false,
-        "internalType": "bytes"
-      },
-      {
-        "name": "operator",
-        "type": "address",
-        "indexed": true,
-        "internalType": "address"
-      },
-      {
-        "name": "vault",
-        "type": "address",
-        "indexed": true,
-        "internalType": "address"
-      },
-      {
-        "name": "slashIndex",
-        "type": "uint256",
-        "indexed": false,
-        "internalType": "uint256"
-      }
-    ],
-    "anonymous": false
-  },
   {
     "type": "event",
     "name": "ValidatorSlashed",
@@ -1475,6 +1444,27 @@
     "name": "FailedInnerCall",
     "inputs": []
   },
+  {
+    "type": "error",
+    "name": "FailedToAddValidatorToValset",
+    "inputs": [
+      {
+        "name": "blsPubkey",
+        "type": "bytes",
+        "internalType": "bytes"
+      },
+      {
+        "name": "vault",
+        "type": "address",
+        "internalType": "address"
+      },
+      {
+        "name": "operator",
+        "type": "address",
+        "internalType": "address"
+      }
+    ]
+  },
   {
     "type": "error",
     "name": "FullRestakeDelegatorNotSupported",

diff --git a/contracts-abi/abi/SettlementGateway.abi b/contracts-abi/abi/SettlementGateway.abi
@@ -256,6 +256,19 @@
     "outputs": [],
     "stateMutability": "nonpayable"
   },
+  {
+    "type": "function",
+    "name": "setRelayer",
+    "inputs": [
+      {
+        "name": "_relayer",
+        "type": "address",
+        "internalType": "address"
+      }
+    ],
+    "outputs": [],
+    "stateMutability": "nonpayable"
+  },
   {
     "type": "function",
     "name": "transferFinalizedIdx",
@@ -410,6 +423,19 @@
     ],
     "anonymous": false
   },
+  {
+    "type": "event",
+    "name": "RelayerSet",
+    "inputs": [
+      {
+        "name": "relayer",
+        "type": "address",
+        "indexed": true,
+        "internalType": "address"
+      }
+    ],
+    "anonymous": false
+  },
   {
     "type": "event",
     "name": "TransferFinalized",
@@ -651,6 +677,11 @@
     "name": "ReentrancyGuardReentrantCall",
     "inputs": []
   },
+  {
+    "type": "error",
+    "name": "RelayerCannotBeZeroAddress",
+    "inputs": []
+  },
   {
     "type": "error",
     "name": "SenderNotRelayer",

diff --git a/contracts-abi/abi/ValidatorOptInRouter.abi b/contracts-abi/abi/ValidatorOptInRouter.abi
@@ -45,8 +45,25 @@
     "outputs": [
       {
         "name": "",
-        "type": "bool[]",
-        "internalType": "bool[]"
+        "type": "tuple[]",
+        "internalType": "struct IValidatorOptInRouter.OptInStatus[]",
+        "components": [
+          {
+            "name": "isVanillaOptedIn",
+            "type": "bool",
+            "internalType": "bool"
+          },
+          {
+            "name": "isAvsOptedIn",
+            "type": "bool",
+            "internalType": "bool"
+          },
+          {
+            "name": "isMiddlewareOptedIn",
+            "type": "bool",
+            "internalType": "bool"
+          }
+        ]
       }
     ],
     "stateMutability": "view"

diff --git a/contracts-abi/clients/L1Gateway/L1Gateway.go b/contracts-abi/clients/L1Gateway/L1Gateway.go
diff --git a/contracts-abi/clients/MevCommitAVS/MevCommitAVS.go b/contracts-abi/clients/MevCommitAVS/MevCommitAVS.go
diff --git a/contracts-abi/clients/MevCommitMiddleware/MevCommitMiddleware.go b/contracts-abi/clients/MevCommitMiddleware/MevCommitMiddleware.go
diff --git a/contracts-abi/clients/SettlementGateway/SettlementGateway.go b/contracts-abi/clients/SettlementGateway/SettlementGateway.go