chore: check return value of IEnumerableSet.add

primev · Nov 7, 2024 · 9c39370 · 9c39370
1 parent eb1e2cd
commit 9c39370
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 2 deletions.
diff --git a/contracts-abi/abi/MevCommitMiddleware.abi b/contracts-abi/abi/MevCommitMiddleware.abi
@@ -1475,6 +1475,27 @@
     "name": "FailedInnerCall",
     "inputs": []
   },
+  {
+    "type": "error",
+    "name": "FailedToAddValidatorToValset",
+    "inputs": [
+      {
+        "name": "blsPubkey",
+        "type": "bytes",
+        "internalType": "bytes"
+      },
+      {
+        "name": "vault",
+        "type": "address",
+        "internalType": "address"
+      },
+      {
+        "name": "operator",
+        "type": "address",
+        "internalType": "address"
+      }
+    ]
+  },
   {
     "type": "error",
     "name": "FullRestakeDelegatorNotSupported",

diff --git a/contracts-abi/clients/MevCommitMiddleware/MevCommitMiddleware.go b/contracts-abi/clients/MevCommitMiddleware/MevCommitMiddleware.go
diff --git a/contracts/contracts/interfaces/IMevCommitMiddleware.sol b/contracts/contracts/interfaces/IMevCommitMiddleware.sol
@@ -161,6 +161,8 @@ interface IMevCommitMiddleware {
 
     error VaultNotReadyToDeregister(address vault, uint256 currentTimestamp, uint256 deregRequestTimestamp);
 
+    error FailedToAddValidatorToValset(bytes blsPubkey, address vault, address operator);
+
     error SlashAmountMustBeNonZero(address vault);
 
     error InvalidVaultEpochDuration(address vault, uint256 vaultEpochDurationSec, uint256 slashPeriodSec);

diff --git a/contracts/contracts/validator-registry/middleware/MevCommitMiddleware.sol b/contracts/contracts/validator-registry/middleware/MevCommitMiddleware.sol
@@ -527,7 +527,8 @@ contract MevCommitMiddleware is IMevCommitMiddleware, MevCommitMiddlewareStorage
             vault: vault,
             operator: operator
         });
-        _vaultAndOperatorToValset[vault][operator].add(blsPubkey);
+        bool success = _vaultAndOperatorToValset[vault][operator].add(blsPubkey);
+        require(success, FailedToAddValidatorToValset(blsPubkey, vault, operator)); // This error would indicate state corruption.
         uint256 position = _getPositionInValset(blsPubkey, vault, operator);
         emit ValRecordAdded(blsPubkey, operator, vault, position);
     }