New Adapter: Missena #3761

ysfbsf · 2024-06-18T13:35:05Z

Related Documentation: prebid/prebid.github.io#5437

github-actions · 2024-06-18T13:35:55Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 4d210b9

missena

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/missena/missena.go:55:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:62:	makeParameter	100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:76:	makeRequest	83.3%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:113:	MakeRequests	96.3%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:162:	readGDPR	100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:182:	MakeBids	94.4%
total:									(statements)	93.7%

przemkaczmarek · 2024-07-26T11:25:02Z

static/bidder-info/missena.yaml

@@ -0,0 +1,16 @@
+endpoint: https://bid.missena.io/
+maintainer:
+  email: [email protected]


this looks like a private email, please enter maintenance email

przemkaczmarek · 2024-07-31T13:40:54Z

static/bidder-params/missena.json

+  "properties": {
+    "apiKey": {
+      "type": "string",
+      "description": "API Key"


You have to add "minimum": 1

You should only add this if you don't want to accept an apiKey of zero length.

przemkaczmarek · 2024-07-31T13:43:17Z

adapters/missena/params_test.go

+}
+
+var validParams = []string{
+	`{"apiKey": ""}`,


when You add "minimum": 1 to missena.json add this example to ivalidParams

przemkaczmarek · 2024-07-31T13:45:36Z

adapters/missena/missena.go

+		if request.Device.IP != "" {
+			headers.Add("X-Forwarded-For", request.Device.IP)
+		} else if request.Device.IPv6 != "" {
+			headers.Add("X-Forwarded-For", request.Device.IPv6)


add test for it.

bsardo · 2024-08-30T19:58:42Z

static/bidder-params/missena.json

+  "properties": {
+    "apiKey": {
+      "type": "string",
+      "description": "API Key"


You should only add this if you don't want to accept an apiKey of zero length.

bsardo · 2024-08-30T20:01:09Z

static/bidder-info/missena.yaml

@@ -0,0 +1,16 @@
+endpoint: https://bid.missena.io/


Endpoint is reachable

curl -i --location --request POST https://bid.missena.io/ HTTP/1.1 403 Forbidden Date: Fri, 30 Aug 2024 20:00:07 GMT Content-Type: text/plain; charset=utf-8 Content-Length: 9 Connection: keep-alive Vary: Origin Forbidden

@bsardo The endpoint is only accessible by calling it with a valid API Key. Example:

curl --location 'https://bid.staging.missena.xyz/?t=PA-34761163' \ --header 'Accept: */*' \ --header 'Accept-Language: en-GB,en-US;q=0.9,en;q=0.8' \ --header 'Cache-Control: no-cache' \ --header 'Connection: keep-alive' \ --header 'Origin: https://publisher.staging.missena.click' \ --header 'Pragma: no-cache' \ --header 'Referer: https://publisher.staging.missena.click/' \ --header 'Sec-Browsing-Topics: ();p=P0000000000000000000000000000000' \ --header 'Sec-Fetch-Dest: empty' \ --header 'Sec-Fetch-Mode: cors' \ --header 'Sec-Fetch-Site: cross-site' \ --header 'User-Agent: Mozilla/5.0 (iPhone; CPU iPhone OS 16_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.6 Mobile/15E148 Safari/604.1' \ --header 'content-type: text/plain' \ --data '{ "adunit": "msna-sticky-dd", "request_id": "53dfce8e0aad03", "test": "smart-banner", "placement": "sticky" }'

All good @ysfbsf. All I'm doing here is proving that I can reach your endpoint and sharing that proof with other reviewers. No action required.

bsardo · 2024-08-30T20:02:19Z

static/bidder-info/missena.yaml

+endpoint: https://bid.missena.io/
+maintainer:
+  email: [email protected]
+gvlVendorID: 687


verified GVL ID:

curl https://vendor-list.consensu.org/v3/vendor-list.json | jq '.vendors."687"' % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 628k 100 628k 0 0 3635k 0 --:--:-- --:--:-- --:--:-- 3655k { "id": 687, "name": "MISSENA", "purposes": [ 1, 2, 3, 4, 5, 6, 7 ], "legIntPurposes": [], "flexiblePurposes": [], "specialPurposes": [ 2 ], "features": [ 2, 3 ], "specialFeatures": [], "cookieMaxAgeSeconds": 31104000, "usesCookies": true, "cookieRefresh": true, "usesNonCookieAccess": true, "dataRetention": { "stdRetention": 360, "purposes": {}, "specialPurposes": {} }, "urls": [ { "langId": "en", "privacy": "https://missena.com/privacy", "legIntClaim": "https://missena.com/privacy" } ], "dataDeclaration": [ 1, 2, 3, 4, 5, 6, 7, 8, 10 ], "deviceStorageDisclosureUrl": "https://ad.missena.io/iab.json" }

@bsardo Do you mean that no need to provide the GVL ID since it's a verified one?

Sorry for the confusion @ysfbsf. No action is required here; you should continue to specify the GVL ID. My comment is just proof to other reviewers that I verified the GVL ID you specified is associated with your bidder.

bsardo · 2024-08-30T21:17:12Z

adapters/missena/params_test.go

+var invalidParams = []string{
+	`{"apiKey": 42}`,
+	`{"placement": 111}`,
+}


I suggest adding the following test cases:

placement is valid but apiKey is omitted since it is required

apiKey is valid but placement is not

bsardo · 2024-08-30T21:18:58Z

adapters/missena/missena_test.go

+
+func TestJsonSamples(t *testing.T) {
+	bidder, buildErr := Builder(openrtb_ext.BidderMissena, config.Adapter{
+		Endpoint: "https://bid.missena.io"},


I recommend using a fake URL for your endpoint to minimize maintenance should you ever change your production endpoint.

bsardo · 2024-08-30T21:51:30Z

adapters/missena/missena.go

+	var tempErrors []error
+	gdprApplies, consentString := readGDPR(request)
+
+	var missenaInternalParams MissenaInternalParams


Nitpick: you could combine this with the gdpr field assignments on lines 144-145 as:

missenaInternalParams := MissenaInternalParams{ GDPR: gdprApplies, GDPRConsent: consentString, }

bsardo · 2024-08-30T22:01:35Z

adapters/missena/missena.go

+	} else if newHttpRequest != nil {
+		httpRequests = append(httpRequests, newHttpRequest)
+	}
+
+	return httpRequests, finalErrors


Do you need the else if? You could probably just do:

httpRequests = append(httpRequests, newHttpRequest) return httpRequests, errors

bsardo · 2024-08-30T22:04:17Z

adapters/missena/missena.go

+	var errors []error
+	return bidResponse, errors


Simplify to return bidResponse, nil

bsardo · 2024-08-30T22:10:24Z

adapters/missena/missena.go

+
+	var missenaInternalParams MissenaInternalParams
+
+	for _, imp := range request.Imp {


It appears you are prepared to handle multiple imps but really you only care that at least one of them is valid as you're just preparing a single request without specifying the impression ID, though you are grabbing the params from the last imp you process. Is this what you want or do you want to grab the info from the first imp?

I suggest adding a test where there are multiple imps with different params, specifically placement. I also think you should add a test where one imp results in an error and the other is well formed.

bsardo · 2024-08-30T22:13:55Z

adapters/missena/missena.go

+		Uri:     url,
+		Headers: headers,
+		Body:    body,
+		ImpIDs:  openrtb_ext.GetImpIDs(request.Imp),


If you're only sending a bid request to your server for one imp, that imp is the one that should be specified here rather than specifying all of the imps.

github-actions · 2024-09-15T14:10:47Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 8c79b48

missena

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/missena/missena.go:55:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:62:	makeParameter	100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:76:	makeRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:113:	MakeRequests	88.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:166:	readGDPR	100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:186:	MakeBids	94.1%
total:									(statements)	93.4%

bsardo · 2024-09-16T17:36:36Z

static/bidder-info/missena.yaml

@@ -0,0 +1,16 @@
+endpoint: https://bid.missena.io/
+maintainer:
+  email: [email protected]


We've sent a test email to [email protected]. Please respond to the email with a message of "received".

@bsardo Can you send the email again?

@ysfbsf Sent

bsardo · 2024-09-16T17:47:23Z

static/bidder-info/missena.yaml

+userSync:
+  redirect:
+    url: https://sync.missena.io/iframe?gdpr={{.GDPR}}&consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}
+    userMacro: $UID


Is this working correctly? I didn't see the redirect to the PBS setuid endpoint with the missena user ID so that it can be set on the PBS cookie.

This does not appear to be working. Two things:

I see iframe in your URL which leads me to believe your user sync is of type iframe instead of redirect. If that's the case, you should indicate as such:

userSync: iframe: url: ... userMacro: $UID

When I initiate a user sync I do not see the redirect to the PBS setuid endpoint, which will be specified in the redirect portion of your user sync query string (redirect={{.RedirectURL}}). This is where your user ID is set on the PBS cookie.

bsardo · 2024-09-16T18:07:00Z

adapters/missena/missenatest/exemplary/ipv6.json

Please move this test under the supplemental folder or rename to simple-banner-ipv6.json.

bsardo · 2024-09-16T18:13:28Z

adapters/missena/missenatest/exemplary/multiple-imps.json

You might want to consider adding a third imp to this test so that two imps are valid and one is invalid. That would make the intended behavior clear for when there are multiple valid imps.

bsardo · 2024-09-16T18:21:37Z

adapters/missena/missena.go

+	if len(httpRequests) == 0 && len(errors) == 0 {
+		errors = append(errors, &errortypes.BadInput{
+			Message: "No valid impressions found",
+		})
+	}


I think you can delete this if block. The only time this condition would be true is if the bid request does not contain any imps but the code upstream will validate that there is at least one impression before calling your adapter.

bsardo · 2024-09-16T18:24:01Z

adapters/missena/missena.go

+	return &missenaRequest
+}
+
+func (a *adapter) makeRequest(missenaParams MissenaInternalParams, reqInfo *adapters.ExtraRequestInfo, imp *openrtb2.Imp, request *openrtb2.BidRequest) (*adapters.RequestData, error) {


Nitpick: instead of passing a pointer to the imp, I suggest just passing the imp ID as a string to keep things simple since that's the only field you're using on the impression.

bsardo · 2024-09-16T18:27:11Z

adapters/missena/missena.go

+func (a *adapter) makeRequest(missenaParams MissenaInternalParams, reqInfo *adapters.ExtraRequestInfo, imp *openrtb2.Imp, request *openrtb2.BidRequest) (*adapters.RequestData, error) {
+
+	url := a.endpoint + "?t=" + missenaParams.ApiKey
+	parameter := a.makeParameter(missenaParams, request)


You could simplify your adapter a bit eliminating a function call by deleting the makeParameter function and moving that function's contents in line so that you construct the MissenaAdRequest instance here.

bsardo · 2024-09-16T18:28:12Z

adapters/missena/missena.go

+	if request.Device != nil {
+		headers.Add("User-Agent", request.Device.UA)
+	}
+
+	if request.Device != nil {


Nitpick: you can simplify your logic by getting rid of the first device nil check and instead moving headers.Add("User-Agent", request.Device.UA) into the second device nil check.

bsardo · 2024-09-16T18:28:35Z

adapters/missena/missena.go

+}
+
+func (a *adapter) MakeRequests(request *openrtb2.BidRequest, requestInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {
+	// print the request


Delete comment

bsardo · 2024-09-16T18:31:24Z

adapters/missena/missena.go

+			consentString = extUser.Consent
+		}
+	}
+	gdprApplies := true


Just checking, are you sure you always want to default to gdpr applies if no gdpr signal has been provided? Perhaps a supplemental test should be added for when gdpr is not set.

github-actions · 2024-09-18T12:01:54Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 00993a5

missena

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/missena/missena.go:55:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:62:	makeRequest	94.1%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:106:	MakeRequests	91.3%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:152:	readGDPR	100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:172:	MakeBids	94.1%
total:									(statements)	94.4%

bsardo

LGTM except for the user sync.

bsardo · 2024-09-20T13:36:32Z

static/bidder-info/missena.yaml

+userSync:
+  redirect:
+    url: https://sync.missena.io/iframe?gdpr={{.GDPR}}&consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}
+    userMacro: $UID


This does not appear to be working. Two things:

I see iframe in your URL which leads me to believe your user sync is of type iframe instead of redirect. If that's the case, you should indicate as such:

userSync: iframe: url: ... userMacro: $UID

When I initiate a user sync I do not see the redirect to the PBS setuid endpoint, which will be specified in the redirect portion of your user sync query string (redirect={{.RedirectURL}}). This is where your user ID is set on the PBS cookie.

github-actions · 2024-10-03T15:22:16Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, af814c7

missena

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/missena/missena.go:55:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:62:	makeRequest	94.1%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:106:	MakeRequests	91.3%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:152:	readGDPR	100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:172:	MakeBids	94.1%
total:									(statements)	94.4%

@dkornet-ad

commit df58baf Author: Brian Sardo <[email protected]> Date: Tue Oct 29 21:05:07 2024 -0400 Cookie Sync: Use max when limit is 0 (prebid#4022) commit db2a872 Author: Brian Sardo <[email protected]> Date: Tue Oct 29 17:20:57 2024 -0400 ORTB 2.6: Full support with down convert for 2.5 adapters (prebid#4019) Co-authored-by: hhhjort <[email protected]> Co-authored-by: Veronika Solovei <[email protected]> commit 1419761 Author: Scott Kay <[email protected]> Date: Tue Oct 29 16:35:05 2024 -0400 Rename Blacklisted Apps to Blocked Apps (prebid#3620) commit ddf897c Author: AlexBVolcy <[email protected]> Date: Tue Oct 29 14:07:49 2024 -0400 Update Cookie Sync Chooser Debug Message to match Java (prebid#3558) commit a23380f Author: Mohammad Nurul Islam Shihan <[email protected]> Date: Tue Oct 29 21:34:31 2024 +0600 ImproveDigital: Remove placementKey & addtlconsent parsing (prebid#3728) commit 03a4abd Author: Alex Maltsev <[email protected]> Date: Tue Oct 22 22:26:45 2024 +0300 Sample: Fix prebid js loading bug on sample html page (prebid#3792) commit 18f6798 Author: Sebastien Boisvert <[email protected]> Date: Tue Oct 22 15:15:07 2024 -0400 Bump Go version to 1.22 in dev containers config (prebid#3983) commit bcf6491 Author: sindhuja-sridharan <[email protected]> Date: Thu Oct 17 15:20:45 2024 -0600 GumGum: Declare ORTB 2.6 support (prebid#3985) commit 451bc44 Author: Bluesea <[email protected]> Date: Thu Oct 17 03:12:50 2024 +0800 BlueSea: Add site capability (prebid#3910) Co-authored-by: prebid-bluesea <[email protected]> commit 8134328 Author: Boris Yu <[email protected]> Date: Wed Oct 16 21:08:50 2024 +0300 Displayio: Make imp.bidfloor optional (prebid#3959) commit b56923c Author: Piotr Jaworski <[email protected]> Date: Tue Oct 15 21:49:39 2024 +0200 RTB House: Resolve AUCTION_PRICE macro (prebid#3901) commit cbe9876 Author: Irakli Gotsiridze <[email protected]> Date: Tue Oct 15 23:30:17 2024 +0400 enable gzip (prebid#3946) commit 5fcbbbf Author: Patrick Loughrey <[email protected]> Date: Tue Oct 15 15:19:47 2024 -0400 Triplelift: Adding flag for 2.6 support (prebid#3966) commit c37951a Author: ym-winston <[email protected]> Date: Tue Oct 15 15:18:54 2024 -0400 update yieldmo.yaml to indicate support for ortb 2.6 (prebid#3968) commit 9bb9b3d Author: bhainesnexxen <[email protected]> Date: Tue Oct 15 12:09:33 2024 -0700 Unruly: Indicate Support for OpenRTB 2.6 (prebid#3984) commit 87d4412 Author: Brian Sardo <[email protected]> Date: Wed Oct 9 19:08:14 2024 +0000 Refactor: Move privacy init up (prebid#3958) commit 64584f6 Author: Brian Sardo <[email protected]> Date: Tue Oct 8 19:52:25 2024 +0000 Refactor: Remove getAuctionBidderRequests (prebid#3957) commit d54c3ed Author: ysfbsf <[email protected]> Date: Tue Oct 8 15:42:40 2024 +0200 New Adapter: Missena (prebid#3761) commit 8689e0d Author: Nick <[email protected]> Date: Mon Oct 7 10:39:59 2024 -0400 Sonobi: native and currency conversion support (prebid#3889) Co-authored-by: bansawbanchee <[email protected]> commit f27bcef Author: dkornet-ad <[email protected]> Date: Thu Oct 3 09:33:54 2024 +0300 New Adapter: Bidmatic (prebid#3731) authored by @dkornet-ad commit 6c154e0 Author: Alexander Pykhteyev <[email protected]> Date: Wed Sep 25 23:08:23 2024 +0700 New Adapter: Streamlyn (prebid#3900) Co-authored-by: apykhteyev <[email protected]> commit 53f51a6 Author: przemkaczmarek <[email protected]> Date: Wed Sep 25 17:53:07 2024 +0200 GPC: Set extension based on header (prebid#3895) commit c42fe53 Author: bkaneyama <[email protected]> Date: Wed Sep 25 07:46:01 2024 -0700 InMobi: mtype support (prebid#3921) commit 8b1b96e Author: Brian Sardo <[email protected]> Date: Wed Sep 25 14:22:18 2024 +0000 Add docs build readme (prebid#3930) commit 4462fce Author: Eugene Dorfman <[email protected]> Date: Wed Sep 25 16:11:45 2024 +0200 51degrees module (prebid#3893) commit 11b6546 Author: Alex Maltsev <[email protected]> Date: Mon Sep 23 16:54:18 2024 +0300 Rubicon: Pass PBS host info to XAPI (prebid#3903) commit 93368cc Author: rtuschkany <[email protected]> Date: Thu Sep 19 23:45:32 2024 +0200 ConnectAd: String/int fix (prebid#3925) commit 905b3a5 Author: ShriprasadM <[email protected]> Date: Thu Sep 19 18:30:20 2024 +0530 Log non bid reasons in bidder framework (prebid#2891) Co-authored-by: Shriprasad Marathe <[email protected]> Co-authored-by: ashish.shinde <[email protected]> Co-authored-by: dhruv.sonone <[email protected]> commit 3c4527e Author: Mikael Lundin <[email protected]> Date: Wed Sep 18 13:38:49 2024 +0200 Adnuntius: Return DSA in bid response (prebid#3777) commit 640b97c Author: lm-ved <[email protected]> Date: Mon Sep 16 12:17:54 2024 +0530 LemmaDigital: change endpoint (prebid#3862) commit 3e24be7 Author: Alexander Pykhteyev <[email protected]> Date: Sat Sep 14 04:04:09 2024 +0700 New Adapter: TGM (prebid#3848) Co-authored-by: apykhteyev <[email protected]> commit ffdd75f Author: Robert Kawecki <[email protected]> Date: Thu Sep 12 21:52:51 2024 +0200 New Adapter: AdTonos (prebid#3853) commit c02ee8c Author: Laurentiu Badea <[email protected]> Date: Thu Sep 12 12:34:46 2024 -0700 Update exchange json tests with correct hb_pb_cat_dur (prebid#3836) commit 7613ff5 Author: Laurentiu Badea <[email protected]> Date: Thu Sep 12 12:27:07 2024 -0700 Update adapter json test framework to validate BidVideo (prebid#3835) commit 6cbedf0 Author: schubert-sc <[email protected]> Date: Wed Sep 11 19:41:53 2024 +0300 Smartx: Declare OpenRTB 2.6 support (prebid#3896) commit e0a21d0 Author: qt-io <[email protected]> Date: Wed Sep 11 19:31:58 2024 +0300 QT: Add tcfeu support (prebid#3892) Co-authored-by: qt-io <[email protected]> commit b920cca Author: Yanivplaydigo <[email protected]> Date: Wed Sep 11 19:19:12 2024 +0300 Playdigo: Add tcfeu support (prebid#3890) commit 6a011ed Author: ccorbo <[email protected]> Date: Wed Sep 11 09:53:54 2024 -0400 Update github.com/rs/cors to v1.11.0 (prebid#3884) Co-authored-by: Chris Corbo <[email protected]> commit ec6a45d Author: Steffen Müller <[email protected]> Date: Wed Sep 4 15:51:44 2024 +0200 Agma: Allow app.bundle to be used as selector for apps (prebid#3780) commit 8237f7f Author: Scott Kay <[email protected]> Date: Tue Sep 3 14:34:56 2024 -0400 Refactor Bid Splitter Privacy Functions (prebid#3645) commit f7caea5 Author: Brian Schmidt <[email protected]> Date: Fri Aug 30 06:47:45 2024 -0700 OpenX: indicate support for OpenRTB 2.6 (prebid#3879) commit e825553 Author: Ben Oraki <[email protected]> Date: Fri Aug 30 16:36:22 2024 +0300 New Adapter: Oraki (prebid#3839) commit 2e2b49f Author: escalax <[email protected]> Date: Fri Aug 30 16:28:04 2024 +0300 New Adapter: Escalax (prebid#3798) commit 4ea0e33 Author: Copper6SSP <[email protected]> Date: Fri Aug 30 16:18:46 2024 +0300 New Adapter: Copper6SSP (prebid#3755) commit 8d7117d Author: Brian Sardo <[email protected]> Date: Tue Aug 27 13:23:34 2024 -0400 Revert "New Module: 51Degrees (prebid#3650)" (prebid#3888) This reverts commit 2606e75. commit 84a8162 Author: Anand Venkatraman <[email protected]> Date: Thu Aug 22 16:14:32 2024 +0530 PulsePoint: ortb 2.6 version and gpp support (prebid#3874) authored by @anand-venkatraman commit bd85ba4 Author: Nick Llerandi <[email protected]> Date: Thu Aug 22 02:15:12 2024 -0400 specifies ortb 2.6 support (prebid#3) (prebid#3876) commit 54f8759 Author: dtbarne <[email protected]> Date: Wed Aug 21 07:26:30 2024 -0500 Update mobilefuse.yaml to indicate support for OpenRTB 2.6 and GPP (prebid#3871) commit 59a5b07 Author: mwang-sticky <[email protected]> Date: Wed Aug 21 20:26:15 2024 +0800 freewheel-adapter: support 2.6 (prebid#3873) commit a556e2d Author: Dubyk Danylo <[email protected]> Date: Wed Aug 21 15:23:39 2024 +0300 Fix currency conversion bug. (prebid#3867) Co-authored-by: ddubyk <[email protected]> commit d161712 Author: Pubrise <[email protected]> Date: Wed Aug 21 12:43:39 2024 +0300 new adapter (prebid#3833) authored by @Pubrise commit e8509e6 Author: bretg <[email protected]> Date: Wed Aug 21 05:40:26 2024 -0400 declare support for ORTB 2.6 (prebid#3872) authored by @bretg commit 6be7244 Author: Saar Amrani <[email protected]> Date: Wed Aug 21 12:37:59 2024 +0300 Update Vidazoo bidder info for GPP support (prebid#3869) commit e4bd6d3 Author: gg-natalia <[email protected]> Date: Sun Aug 18 06:52:28 2024 -0300 ADTS-455 remove video validations (prebid#3842) authored by @gg-natalia commit 2606e75 Author: James Rosewell <[email protected]> Date: Fri Aug 16 14:20:22 2024 +0100 New Module: 51Degrees (prebid#3650) Co-authored-by: James Rosewell <[email protected]> Co-authored-by: Marin Miletic <[email protected]> Co-authored-by: Sarana-Anna <[email protected]> Co-authored-by: Eugene Dorfman <[email protected]> Co-authored-by: Krasilchuk Yaroslav <[email protected]> commit 0e9b234 Author: Antonios Sarhanis <[email protected]> Date: Tue Aug 13 18:28:44 2024 +1000 Use format=prebid on adserver requests. (prebid#3846) commit 4d64623 Author: ownAdx <[email protected]> Date: Mon Aug 12 18:51:53 2024 +0530 OwnAdx: Bidder param and URL updates (prebid#3813) Co-authored-by: Hina Yadav <[email protected]> commit 2a19924 Author: ahmadlob <[email protected]> Date: Mon Aug 12 16:09:23 2024 +0300 taboola-support-app-in-prebid-server (prebid#3795) commit 4f177ca Author: benben2001 <[email protected]> Date: Mon Aug 12 21:07:38 2024 +0800 New Adapter: MeloZen (prebid#3784)

This reverts commit 6c2f8e1.

New Adapter: Missena

4d210b9

ysfbsf mentioned this pull request Jun 18, 2024

New Prebid Server Adapter: Missena prebid/prebid.github.io#5437

Merged

3 tasks

bsardo assigned przemkaczmarek and bsardo Jul 24, 2024

przemkaczmarek reviewed Jul 26, 2024

View reviewed changes

przemkaczmarek reviewed Jul 31, 2024

View reviewed changes

bsardo reviewed Aug 30, 2024

View reviewed changes

New Adapter: Missena - Updated

8c79b48

ysfbsf requested review from bsardo and przemkaczmarek September 15, 2024 14:31

bsardo reviewed Sep 16, 2024

View reviewed changes

Code cleaning

00993a5

bsardo reviewed Sep 20, 2024

View reviewed changes

przemkaczmarek previously approved these changes Sep 25, 2024

View reviewed changes

przemkaczmarek self-requested a review September 25, 2024 15:23

Replace "redirect" by "iframe" for Missena userSync

af814c7

ysfbsf dismissed przemkaczmarek’s stale review via af814c7 October 3, 2024 15:21

bsardo approved these changes Oct 7, 2024

View reviewed changes

przemkaczmarek approved these changes Oct 8, 2024

View reviewed changes

bsardo merged commit d54c3ed into prebid:master Oct 8, 2024
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Oct 8, 2024

Port PR from PBS-Go: New Adapter: Missena prebid/prebid-server-java#3490

Closed

krdzo pushed a commit to Ogury/prebid-server that referenced this pull request Oct 30, 2024

New Adapter: Missena (prebid#3761)

6c2f8e1

krdzo added a commit to Ogury/prebid-server that referenced this pull request Oct 30, 2024

Revert "New Adapter: Missena (prebid#3761)"

e17089b

This reverts commit 6c2f8e1.


		var missenaInternalParams MissenaInternalParams

		for _, imp := range request.Imp {

New Adapter: Missena #3761

New Adapter: Missena #3761

Conversation

ysfbsf commented Jun 18, 2024

github-actions bot commented Jun 18, 2024

Code coverage summary

missena

Choose a reason for hiding this comment

Choose a reason for hiding this comment

przemkaczmarek Jul 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 15, 2024

Code coverage summary

missena

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 18, 2024

Code coverage summary

missena

bsardo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 3, 2024

Code coverage summary

missena

przemkaczmarek Jul 31, 2024 •

edited

Loading