OwnAdx: Bidder param and URL updates (prebid#3813)

Co-authored-by: Hina Yadav <[email protected]>
tamedia-adtec · Aug 12, 2024 · 4d64623 · 4d64623
1 parent 2a19924
commit 4d64623
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 12 deletions.
diff --git a/adapters/ownadx/ownadx.go b/adapters/ownadx/ownadx.go
@@ -56,9 +56,9 @@ func createBidRequest(rtbBidRequest *openrtb2.BidRequest, imps []openrtb2.Imp) *
 }
 func (adapter *adapter) buildEndpointURL(params *openrtb_ext.ExtImpOwnAdx) (string, error) {
 	endpointParams := macros.EndpointTemplateParams{
-		ZoneID:    params.SspId,
-		AccountID: params.SeatId,
-		SourceId:  params.TokenId,
+		SspID:   params.SspId, // Macro
+		SeatID:  params.SeatId,
+		TokenID: params.TokenId,
 	}
 	return macros.ResolveMacros(adapter.endpoint, endpointParams)
 }
@@ -124,6 +124,7 @@ func groupImpsByExt(imps []openrtb2.Imp) (map[openrtb_ext.ExtImpOwnAdx][]openrtb
 }
 
 func (adapter *adapter) MakeBids(internalRequest *openrtb2.BidRequest, externalRequest *adapters.RequestData, response *adapters.ResponseData) (*adapters.BidderResponse, []error) {
+
 	if response.StatusCode == http.StatusNoContent {
 		return nil, nil
 	}
@@ -159,6 +160,7 @@ func (adapter *adapter) MakeBids(internalRequest *openrtb2.BidRequest, externalR
 
 	seatBid := bidResp.SeatBid[0]
 	bidResponse := adapters.NewBidderResponseWithBidsCapacity(len(bidResp.SeatBid[0].Bid))
+
 	if len(seatBid.Bid) == 0 {
 		return nil, []error{
 			&errortypes.BadServerResponse{
@@ -169,7 +171,6 @@ func (adapter *adapter) MakeBids(internalRequest *openrtb2.BidRequest, externalR
 	for i := 0; i < len(seatBid.Bid); i++ {
 		var bidType openrtb_ext.BidType
 		bid := seatBid.Bid[i]
-
 		bidType, err := getMediaType(bid)
 		if err != nil {
 			return nil, []error{&errortypes.BadServerResponse{

diff --git a/adapters/ownadx/ownadx_test.go b/adapters/ownadx/ownadx_test.go
@@ -11,7 +11,7 @@ import (
 
 func TestJsonSamples(t *testing.T) {
 	bidder, buildErr := Builder(openrtb_ext.BidderOwnAdx, config.Adapter{
-		Endpoint: "https://pbs.prebid-ownadx.com/bidder/bid/{{.AccountID}}/{{.ZoneID}}?token={{.SourceId}}"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})
+		Endpoint: "https://pbs.prebid-ownadx.com/bidder/bid/{{.SeatID}}/{{.SspID}}?token={{.TokenID}}"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})
 
 	assert.NoError(t, buildErr)
 	adapterstest.RunJSONBidderTest(t, "ownadxtest", bidder)

diff --git a/macros/macros.go b/macros/macros.go
@@ -18,6 +18,9 @@ type EndpointTemplateParams struct {
 	PageID      string
 	SupplyId    string
 	SspId       string
+	SspID       string
+	SeatID      string
+	TokenID     string
 }
 
 // UserSyncPrivacy specifies privacy policy macros, represented as strings, for user sync urls.

diff --git a/static/bidder-info/ownadx.yaml b/static/bidder-info/ownadx.yaml
@@ -1,4 +1,4 @@
-endpoint: "https://pbs.prebid-ownadx.com/bidder/bid/{{.AccountID}}/{{.ZoneID}}?token={{.SourceId}}"
+endpoint: "https://pbs.prebid-ownadx.com/bidder/bid/{{.SeatID}}/{{.SspID}}?token={{.TokenID}}"
 maintainer:
   email: [email protected]
 capabilities:

diff --git a/static/bidder-params/ownadx.json b/static/bidder-params/ownadx.json
@@ -18,10 +18,5 @@
       "description": "Token ID"
     }
   },
-
-  "oneOf": [
-    { "required": ["sspId"] },
-    { "required": ["feedId"] },
-    { "required": ["token"] }
-  ]
+  "required": ["sspId","seatId","tokenId"]
 }