-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Adapter: Bidmatic #3731
New Adapter: Bidmatic #3731
Conversation
Code coverage summaryNote:
bidmaticRefer here for heat map coverage report
|
Code coverage summaryNote:
bidmaticRefer here for heat map coverage report
|
Code coverage summaryNote:
bidmaticRefer here for heat map coverage report
|
Code coverage summaryNote:
bidmaticRefer here for heat map coverage report
|
Code coverage summaryNote:
bidmaticRefer here for heat map coverage report
|
Code coverage summaryNote:
bidmaticRefer here for heat map coverage report
|
Code coverage summaryNote:
bidmaticRefer here for heat map coverage report
|
@@ -0,0 +1,18 @@ | |||
endpoint: "http://adapter.bidmatic.io/pbs/ortb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curl -i --location --request POST 'http://adapter.bidmatic.io/pbs/ortb'
HTTP/1.1 400 Bad Request
Server: Bidmatic
Date: Fri, 28 Jun 2024 10:56:06 GMT
Content-Type: text/plain; charset=utf-8
Content-Length: 16
Access-Control-Allow-Origin: *
Access-Control-Allow-Credentials: true
Connection: Keep-Alive
Permissions-Policy: browsing-topics=()
X-Robots-Tag: noindex
endpoint is reachable
@@ -0,0 +1,18 @@ | |||
endpoint: "http://adapter.bidmatic.io/pbs/ortb" | |||
maintainer: | |||
email: "[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prebid team has sent email to verify above maintainers email. Requesting to responding back on email thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
received response from [email protected]
endpoint: "http://adapter.bidmatic.io/pbs/ortb" | ||
maintainer: | ||
email: "[email protected]" | ||
gvlVendorID: 1134 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verified gvl id
curl https://vendor-list.consensu.org/v3/vendor-list.json | jq '.vendors."1134"'
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 614k 100 614k 0 0 5831k 0 --:--:-- --:--:-- --:--:-- 5853k
{
"id": 1134,
"name": "Bidmatic Inc",
"purposes": [
1,
2,
7
],
"legIntPurposes": [],
"flexiblePurposes": [],
"specialPurposes": [
1,
2
],
"features": [
3
],
"specialFeatures": [],
"cookieMaxAgeSeconds": 8035200,
"usesCookies": true,
"cookieRefresh": true,
"usesNonCookieAccess": true,
"dataRetention": {
"stdRetention": 90,
"purposes": {},
"specialPurposes": {
"2": 0
}
},
"urls": [
{
"langId": "en",
"privacy": "https://bidmatic.io/privacy-policy/",
"legIntClaim": "https://bidmatic.io/tos/"
}
],
"dataDeclaration": [
1,
2,
3,
4,
6,
7,
8,
11
],
"deviceStorageDisclosureUrl": "https://bidmatic.io/.well-known/deviceStorage.json"
}
Code coverage summaryNote:
bidmaticRefer here for heat map coverage report
|
Create doc PR in https://github.com/prebid/prebid.github.io repo and link doc PR in this PR's description. Refer prebid/prebid.github.io#5395 as example |
Seems like some traction was here =) @przemkaczmarek can we make this bidder go live ? Thank you |
adapters/bidmatic/bidmatic.go
Outdated
for i := 0; i < len(sb.Bid); i++ { | ||
|
||
bid := sb.Bid[i] | ||
|
||
impOK = false | ||
mediaType := openrtb_ext.BidTypeBanner | ||
bid.MType = openrtb2.MarkupBanner | ||
for _, imp := range bidReq.Imp { | ||
if imp.ID == bid.ImpID { | ||
|
||
impOK = true | ||
|
||
if imp.Video != nil { | ||
mediaType = openrtb_ext.BidTypeVideo | ||
bid.MType = openrtb2.MarkupVideo | ||
break | ||
} | ||
} | ||
} | ||
|
||
if !impOK { | ||
errors = append(errors, &errortypes.BadServerResponse{ | ||
Message: fmt.Sprintf("ignoring bid id=%s, request doesn't contain any impression with id=%s", bid.ID, bid.ImpID), | ||
}) | ||
continue | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkornet-ad any feedback on above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkornet-ad @GeneGenie any feedback on above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@przemkaczmarek ready
@dkornet-ad friendly ping to address comments |
Code coverage summaryNote:
bidmaticRefer here for heat map coverage report
|
@onkarvhanumante fixed |
@przemkaczmarek resolved |
Code coverage summaryNote:
bidmaticRefer here for heat map coverage report
|
@przemkaczmarek kindly reminder to review =) thanks |
Code coverage summaryNote:
bidmaticRefer here for heat map coverage report
|
@dkornet-ad https://github.com/prebid/prebid-server/pull/3731/files#r1762391035 one comment otherwise LGTM |
Code coverage summaryNote:
bidmaticRefer here for heat map coverage report
|
No description provided.