Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediago support prebid server #5395

Merged
merged 4 commits into from
Jun 28, 2024
Merged

mediago support prebid server #5395

merged 4 commits into from
Jun 28, 2024

Conversation

SylviaF
Copy link
Contributor

@SylviaF SylviaF commented Jun 5, 2024

🏷 Type of documentation

  • new bid adapter

  • update bid adapter
    Add MediaGo server adapter.

  • new feature

  • text edit only (wording, typos)

  • bugfix (code examples)

  • new examples

📋 Checklist

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit e92ac85
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6678d547ac5b9b000849300c
😎 Deploy Preview https://deploy-preview-5395--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -3,11 +3,14 @@ layout: bidder
title: MediaGo
description: MediaGo Prebid Bidder Adapter
biddercode: mediago
media_types: banner
media_types: banner,native
prebid_member: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Baidu a member company now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisHuie We did join the prebid.org Slack group. But I'm not so sure if that means we are members.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with my colleague, and we confirmed that we are members. I will update the code accordingly.

@@ -26,7 +29,8 @@ The MediaGo Bidding adapter requires setup before beginning. Please contact us a
{: .table .table-bordered .table-striped }
| Name | Scope | Description | Example | Type |
|---------------|----------|-----------------------|-----------|-----------|
| `token` | required | publisher token | `'1e100887dd614b7f69fdd1360437'` | `string` |
| `token` | required | publisher token, This parameter expects all imps to be the same | `'1e100887dd614b7f69fdd1360437'` | `string` |
| `region` | recommend | Server region for PBS request: US for US Region, EU for EU Region, APAC for APAC Region, default is US. This parameter expects all imps to be the same. | `'US'` | `string` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark this parameter as being available for PBS only. Apparently the "test" and "bidfloor" parameters are PBJS only. (though we'd prefer you got rid of the bidfloor param and just read the floor in the standard way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bretg Thanks for your advice. I have changed it.

@bretg bretg added LGTM and removed needs work labels Jun 24, 2024
@ChrisHuie ChrisHuie merged commit cd4d431 into prebid:master Jun 28, 2024
5 checks passed
BIGOAds pushed a commit to BIGOAds/prebid.github.io that referenced this pull request Jul 5, 2024
* mediago support prebid server

* MediaGo Baidu is Prebid member

* mark parameters' availability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants