-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Adapter: Copper6SSP #3755
New Adapter: Copper6SSP #3755
Conversation
Code coverage summaryNote:
copper6sspRefer here for heat map coverage report
|
@bretg @onkarvhanumante @gargcreation1992 @bsardo @SyntaxNode @Sonali-More-Xandr please respond to this pull request |
Hi @Copper6SSP. Thanks for your patience. We've been quite busy due to summer vacations and internal priorities resulting in the delay. We'll review shortly. |
@bsardo thanks for answering. Do you know any deadlines for reviewing a pull request? |
Hi @Copper6SSP, our pace has slowed significantly from the norm recently due to competing internal priorities and vacations. This is temporary. Peter reviewed and I will review sometime today. Sorry again for the delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two nip comments
Code coverage summaryNote:
copper6sspRefer here for heat map coverage report
|
updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good; I left a few minor comments.
@@ -0,0 +1,21 @@ | |||
endpoint: "https://endpoint.copper6.com/" | |||
maintainer: | |||
email: "[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've sent an email to this address to confirm it is correct. Please respond to the email with a "received" message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed
adapters/copper6ssp/copper6ssptest/exemplary/simple-banner.json
Outdated
Show resolved
Hide resolved
Code coverage summaryNote:
copper6sspRefer here for heat map coverage report
|
@bsardo @przemkaczmarek fixed all, review please |
Code coverage summaryNote:
copper6sspRefer here for heat map coverage report
|
Hi @Copper6SSP, we noticed that your adapter is basically the same as the Playdigo and QT adapters that were recently merged into the project, as well as the Oraki adapter that is currently under review. We would like to point out that aliasing an adapter may be an option for you and is preferable if you and another bidder share the same server. You can read more about aliasing here: aliasing an adapter. Please let us know your thoughts on whether this is a possibility for you. |
Code coverage summaryNote:
copper6sspRefer here for heat map coverage report
|
@bsardo Thanks for the review. Unfortunately, this does not suit us, since we have separate servers that do not belong to the above mentioned adapters. |
} | ||
}, | ||
{ | ||
"id": "test-imp-id2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked
doc - prebid/prebid.github.io#5426