Core package organization, and renaming to ReactPlayer
#93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of this PR merges most of the sub-packages inside the
core/
folder under thecore/player
package. Most of the API of thecore/player
remains unchanged (as many of these modules were exported under@player-ui/player
anyway).The big motivation for reducing the number of transitive dependencies is to reduce the churn for updating versions. Many times the transitive dependencies don't get properly resolved/shared without manual editing of the lockfiles generated by
yarn
/npm
. This should help to reduce that variability down to just@player-ui/player
and@player-ui/react
.This PR also does the same thing for
@player-ui/react
, which now includes the export for theReactAsset
component to render in the player tree. In order to avoid conflict w/ theAsset
interface from@player-ui/types
, theAsset
component was renamed toReactAsset
, along with the entireWebPlayer
toReactPlayer
to better describe it's platform dependence.@player-ui/react
no longer requires the use ofreact-dom
Fixes #87
Version
Published prerelease version:
0.3.0-next.4
Changelog
🚀 Enhancement
ReactPlayer
#93 (@adierkens)🐛 Bug Fix
📝 Documentation
Authors: 7