Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] fix runtime warnings for published variables in Xcode14 #84

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

hborawski
Copy link
Contributor

@hborawski hborawski commented Sep 26, 2022

Xcode14 displays runtime warnings for some published variables when they are updated

This was not reproducible with the reference assets but with an integration that sets up several values in EnvironmentValues

Version

Published prerelease version: 0.3.0-next.1

Changelog

🚀 Enhancement

🐛 Bug Fix

📝 Documentation

Authors: 7

@hborawski hborawski added the patch Increment the patch version when merged label Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 77.32% // Head: 77.01% // Decreases project coverage by -0.30% ⚠️

Coverage data is based on head (d65d342) compared to base (ea59026).
Patch coverage: 71.12% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   77.32%   77.01%   -0.31%     
==========================================
  Files         130      129       -1     
  Lines        4427     4499      +72     
  Branches     1093     1114      +21     
==========================================
+ Hits         3423     3465      +42     
- Misses        727      754      +27     
- Partials      277      280       +3     
Impacted Files Coverage Δ
core/player/src/plugins/flow-exp-plugin.ts 93.33% <ø> (-1.41%) ⬇️
core/player/src/validation/controller.ts 84.49% <ø> (ø)
core/view/src/view.ts 65.90% <ø> (ø)
tools/cli/src/commands/dsl/compile.ts 0.00% <0.00%> (ø)
tools/cli/src/utils/babel-register.ts 0.00% <ø> (ø)
language/dsl/src/compiler/compiler.ts 51.66% <28.57%> (-21.87%) ⬇️
core/player/src/player.ts 78.29% <50.00%> (-1.39%) ⬇️
core/view/src/plugins/applicability.ts 85.71% <75.00%> (-14.29%) ⬇️
core/view/src/plugins/template-plugin.ts 80.00% <81.81%> (ø)
core/view/src/parser/index.ts 79.01% <86.66%> (+1.63%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant