Enhancement/Parser Rewrite for plugins

[mercillo]

Changed the parsers to be built around the plugins. The plugins should determine what the nodetypes are for template, applicability and switches. Based on that nodetype, they should parse their own respective nodes.

Version

Published prerelease version: 0.3.0-next.0

Changelog

🚀 Enhancement

• Enhancement/Parser Rewrite for plugins #80 ([email protected] @mercillo)

🐛 Bug Fix

• [iOS] make some additional properties public #82 (@hborawski)
• change platform groupid #81 ([email protected] @brocollie08)
• [iOS] add registerPlugin(_:) to HeadlessPlayer API #79 (@hborawski)
• Cleanup Android dependencies #77 (@sugarmanz)

📝 Documentation

• Add algolia search to /latest/ site #76 (@adierkens)

Authors: 7

• @brocollie08
• Adam Dierkens (@adierkens)
• brocollie08 ([email protected])
• Harris Borawski (@hborawski)
• Jeremiah Zucker (@sugarmanz)
• Marlon Ercillo (@mercillo)
• mercillo ([email protected])

[codecov]

Codecov Report

Base: 77.32% // Head: 77.01% // Decreases project coverage by -0.30% ⚠️

Coverage data is based on head (04c8486) compared to base (ea59026).
Patch coverage: 71.12% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   77.32%   77.01%   -0.31%     
==========================================
  Files         130      129       -1     
  Lines        4427     4499      +72     
  Branches     1093     1114      +21     
==========================================
+ Hits         3423     3465      +42     
- Misses        727      754      +27     
- Partials      277      280       +3     

Impacted Files	Coverage Δ
core/player/src/plugins/flow-exp-plugin.ts	93.33% <ø> (-1.41%)	⬇️
core/player/src/validation/controller.ts	84.49% <ø> (ø)
core/view/src/view.ts	65.90% <ø> (ø)
tools/cli/src/commands/dsl/compile.ts	0.00% <0.00%> (ø)
tools/cli/src/utils/babel-register.ts	0.00% <ø> (ø)
language/dsl/src/compiler/compiler.ts	51.66% <28.57%> (-21.87%)	⬇️
core/player/src/player.ts	78.29% <50.00%> (-1.39%)	⬇️
core/view/src/plugins/applicability.ts	85.71% <75.00%> (-14.29%)	⬇️
core/view/src/plugins/template-plugin.ts	80.00% <81.81%> (ø)
core/view/src/parser/index.ts	79.01% <86.66%> (+1.63%)	⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[KetanReddy]

In general I think this should be fine, it does look like there are some cases not covered by tests. Can we get a few more tests just to cover those?

[mercillo]

In general I think this should be fine, it does look like there are some cases not covered by tests. Can we get a few more tests just to cover those?

added some more unit tests!

[hborawski]

applitools diff looks to be a view presentation timing diff, i added a delay in iOS before calling applitools, i can do it for android as well

[adierkens]

What's the difference between currentValue and objToParse?

[mercillo]

there are cases when the current value is just a value with nothing to parse, so it doesnt contain a children element on the return

[mercillo]

looks like the codecov patch is hitting the compiler.ts file again which can be ignored haha