Cleanup Android dependencies #77
Conversation
sugarmanz
force-pushed
the
cleanup-android-deps
branch
from
8dfbaab to
4f87612
Compare
| ), | ||
| transition = "1.4.1", | ||
| ), | ||
| dagger = "2.35.1", |
There was a problem hiding this comment.
i recall you saying you needed to add this for some odd reason, do we still need this
There was a problem hiding this comment.
dagger is needed to load the grab common repository -- at least it was when i initially integrated. it'd be cool to get off that repo eventually
| @@ -13,4 +13,4 @@ load("@grab_bazel_common//:workspace_defs.bzl", grab = "GRAB_BAZEL_COMMON_ARTIFA | |||
|
|
|||
| tooling = distribution + grab | |||
|
|
|||
| maven = common + core + graaljs + j2v8 + utils + testutils + perf + plugins + tooling + android + demo | |||
| maven = remove_duplicates(common + core + graaljs + j2v8 + utils + testutils + perf + plugins + tooling + android) | |||
|
|
||
| main_exports = [ | ||
| "//android/player", | ||
| ] | ||
|
|
||
| main_deps = main_exports + parse_coordinates(maven) + [ | ||
| main_deps = main_exports + parse_coordinates(maven_main) + [ |
There was a problem hiding this comment.
since maven_main doesn't have anything in it right now, maybe remove the parse_coordinates, i'm not against keeping the maven_main though
There was a problem hiding this comment.
This is more for the patternization of deps.bzl. If someone wants to add another dependency, all they need to do right now is add "androidx.core:core-ktx:%s" % versions.androidx.core" and that will automatically be pulled into the maven_install_and_ converted to the corresponding@maven//:androidx_core_core_ktx` Bazel reference.
If we remove the parse_coordinates, then they'd need to do:
converted to the corresponding
@maven//:androidx_core_core_ktxBazel reference.
manually, or reintroduce the parse_coordinates method.
| "androidx.lifecycle:lifecycle-runtime-ktx:%s" % versions.androidx.lifecycle, | ||
| "androidx.lifecycle:lifecycle-viewmodel-ktx:%s" % versions.androidx.lifecycle, | ||
|
|
||
| # Default fallback |
There was a problem hiding this comment.
what's constraintlayout gotta do with default fallback? you mean the fallbackView? is that the only place we use it..?
There was a problem hiding this comment.
I would love to not have a dependency on constraintlayout in the base android player dep, but we are using it to build the default fallback view:
No description provided.