Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpreter useless code removal #4860

Open
ywqzzy opened this issue May 11, 2022 · 0 comments · Fixed by #6219
Open

Interpreter useless code removal #4860

ywqzzy opened this issue May 11, 2022 · 0 comments · Fixed by #6219
Assignees
@ywqzzy
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@ywqzzy
Copy link
Contributor

ywqzzy commented May 11, 2022 •
edited
Loading

Enhancement

There are many interpreter class from upstream clickhouse that are not used.
For code readability, It's better to drop all of them.

There are several types of interpreter class, they are listed as follow:

  1. SelectQuery
  2. AlterQuery
  3. DropQuery
  4. CreateQuery
  5. RenameQuery
  6. ManageQuery
  7. ShowTablesQuery
  8. OptimizeQuery Interpreter: Remove Optimize query. #4589
  9. TruncateQuery Interpreter: Remove Truncate query #4587
  10. TableProperties Interpreter: Remove Table properties query #4586
  11. CheckQuery Remove useless CheckQuery related files. #4569 Interpreter: Remove CheckQuery. #4568
  12. KillQUery Remove useless KillQuery related files. #4567 Interpreter: Remove kill Query #4564
  13. SystemQuery Interpreter: Remove system query #4590
  14. UseQuery
  15. SetQuery
  16. DeleteQuery Interpreter: Remove Optimize query. #4589
  17. DescribeQuery
  18. ExistQuery
  19. InsertQuery
  20. ShowProcesslist
@ywqzzy ywqzzy added the type/enhancement The issue or PR belongs to an enhancement. label May 11, 2022
@ywqzzy ywqzzy mentioned this issue May 11, 2022
Merged
12 tasks
@ywqzzy ywqzzy self-assigned this May 11, 2022
ti-chi-bot pushed a commit that referenced this issue May 11, 2022
@ywqzzy
Interpreter: Remove Optimize query. (#4589)
a446006 
ref #4860
This was referenced May 11, 2022
Merged
Merged
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue May 11, 2022
@ywqzzy
Interpreter: Remove Truncate query (#4587)
d99b0b7 
ref #4860
ti-chi-bot pushed a commit that referenced this issue May 12, 2022
@ywqzzy
Interpreter: Remove Table properties query (#4586)
ace1369 
ref #4860
ti-chi-bot pushed a commit that referenced this issue May 12, 2022
@ywqzzy
Interpreter: Remove delete query (#4594)
efc93ad 
ref #4860
ti-chi-bot pushed a commit that referenced this issue May 13, 2022
@ywqzzy
Interpreter: Remove system query (#4590)
2dc22fd 
ref #4860
@Lloyd-Pottiger Lloyd-Pottiger mentioned this issue Oct 31, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Nov 1, 2022
@Lloyd-Pottiger
remove useless arrayJoin (#6219)
81660bd 
close #4860
@ywqzzy ywqzzy reopened this Nov 1, 2022
CalvinNeo pushed a commit to CalvinNeo/tiflash that referenced this issue Nov 4, 2022
@Lloyd-Pottiger @CalvinNeo
remove useless arrayJoin (pingcap#6219)
d2da524 
close pingcap#4860

Signed-off-by: CalvinNeo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ywqzzy ywqzzy

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove useless arrayJoin Lloyd-Pottiger/tiflash
1 participant
@ywqzzy