Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpreter: Remove delete query #4594

Merged
merged 5 commits into from
May 12, 2022
Merged

Interpreter: Remove delete query #4594

merged 5 commits into from
May 12, 2022

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Apr 6, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4860

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • Lloyd-Pottiger

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 6, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Apr 6, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 6, 2022

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Interpreters/InterpreterFactory.cpp          75                75     0.00%           2                 2     0.00%         111               111     0.00%          50                50     0.00%
Parsers/ParserQuery.cpp                      17                17     0.00%           1                 1     0.00%          21                21     0.00%          18                18     0.00%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                        92                92     0.00%           3                 3     0.00%         132               132     0.00%          68                68     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16994      9505             44.07%    191206  96205        49.69%

full coverage report (for internal network access only)

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Apr 7, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 7, 2022

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Interpreters/InterpreterFactory.cpp          75                75     0.00%           2                 2     0.00%         111               111     0.00%          50                50     0.00%
Parsers/ParserQuery.cpp                      17                17     0.00%           1                 1     0.00%          21                21     0.00%          18                18     0.00%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                        92                92     0.00%           3                 3     0.00%         132               132     0.00%          68                68     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17012      9507             44.12%    191666  96268        49.77%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/needs-linked-issue labels May 11, 2022
@ywqzzy ywqzzy changed the title [DNM] Remove delete query Interpreter: Remove delete query May 11, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 11, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented May 12, 2022

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e352688

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented May 12, 2022

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eb994d1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented May 12, 2022

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Interpreters/InterpreterFactory.cpp          57                57     0.00%           2                 2     0.00%          85                85     0.00%          38                38     0.00%
Parsers/ParserQuery.cpp                      13                 6    53.85%           1                 0   100.00%          17                 0   100.00%          14                13     7.14%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                        70                63    10.00%           3                 2    33.33%         102                85    16.67%          52                51     1.92%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18134      9798             45.97%    202359  98021        51.56%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit efc93ad into pingcap:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@SeaRise SeaRise SeaRise approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@windtalker windtalker Awaiting requested review from windtalker

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ywqzzy @ti-chi-bot @sre-bot @JaySon-Huang @SeaRise @Lloyd-Pottiger