Skip to content

Commit

Permalink
remove useless arrayJoin (#6219)
Browse files Browse the repository at this point in the history 
close #4860
  • Loading branch information
@Lloyd-Pottiger
Lloyd-Pottiger authored Nov 1, 2022
1 parent 10ebe6b commit 81660bd
Show file tree
Hide file tree
Showing 13 changed files with 107 additions and 871 deletions.
1 change: 0 additions & 1 deletion dbms/src/Columns/IColumn.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ class IColumn : public COWPtr<IColumn>

/** Copies each element according offsets parameter.
* (i-th element should be copied offsets[i] - offsets[i - 1] times.)
* It is necessary in ARRAY JOIN operation.
*/
using Offset = UInt64;
using Offsets = PaddedPODArray<Offset>;
Expand Down
83 changes: 14 additions & 69 deletions dbms/src/Functions/FunctionsMiscellaneous.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,6 @@ extern const int FUNCTION_THROW_IF_VALUE_IS_NON_ZERO;
* in(x, set) - function for evaluating the IN
* notIn(x, set) - and NOT IN.
*
* arrayJoin(arr) - a special function - it can not be executed directly;
* is used only to get the result type of the corresponding expression.
*
* replicate(x, arr) - creates an array of the same size as arr, all elements of which are equal to x;
* for example: replicate(1, ['a', 'b', 'c']) = [1, 1, 1].
*
Expand Down Expand Up @@ -792,17 +789,17 @@ class FunctionIn : public IFunction
}
/// Second argument must be ColumnSet.
ColumnPtr column_set_ptr = block.getByPosition(arguments[1]).column;
const ColumnSet * column_set = typeid_cast<const ColumnSet *>(&*column_set_ptr);
const auto * column_set = typeid_cast<const ColumnSet *>(&*column_set_ptr);
if (!column_set)
throw Exception("Second argument for function '" + getName() + "' must be Set; found " + column_set_ptr->getName(),
ErrorCodes::ILLEGAL_COLUMN);

Block block_of_key_columns;

/// First argument may be tuple or single column.
const ColumnTuple * tuple = typeid_cast<const ColumnTuple *>(left_arg.column.get());
const auto * tuple = typeid_cast<const ColumnTuple *>(left_arg.column.get());
const ColumnConst * const_tuple = checkAndGetColumnConst<ColumnTuple>(left_arg.column.get());
const DataTypeTuple * type_tuple = typeid_cast<const DataTypeTuple *>(left_arg.type.get());
const auto * type_tuple = typeid_cast<const DataTypeTuple *>(left_arg.type.get());

ColumnPtr materialized_tuple;
if (const_tuple)
Expand Down Expand Up @@ -1005,65 +1002,14 @@ class FunctionIdentity : public IFunction
};


class FunctionArrayJoin : public IFunction
{
public:
static constexpr auto name = "arrayJoin";
static FunctionPtr create(const Context &)
{
return std::make_shared<FunctionArrayJoin>();
}


/// Get the function name.
String getName() const override
{
return name;
}

size_t getNumberOfArguments() const override
{
return 1;
}

/** It could return many different values for single argument. */
bool isDeterministic() const override { return false; }

bool isDeterministicInScopeOfQuery() const override
{
return false;
}

DataTypePtr getReturnTypeImpl(const DataTypes & arguments) const override
{
const DataTypeArray * arr = checkAndGetDataType<DataTypeArray>(&*arguments[0]);
if (!arr)
throw Exception("Argument for function " + getName() + " must be Array.", ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT);

return arr->getNestedType();
}

void executeImpl(Block & /*block*/, const ColumnNumbers & /*arguments*/, size_t /*result*/) const override
{
throw Exception("Function " + getName() + " must not be executed directly.", ErrorCodes::FUNCTION_IS_SPECIAL);
}

/// Because of function cannot be executed directly.
bool isSuitableForConstantFolding() const override
{
return false;
}
};


FunctionPtr FunctionReplicate::create(const Context &)
{
return std::make_shared<FunctionReplicate>();
}

DataTypePtr FunctionReplicate::getReturnTypeImpl(const DataTypes & arguments) const
{
const DataTypeArray * array_type = checkAndGetDataType<DataTypeArray>(&*arguments[1]);
const auto * array_type = checkAndGetDataType<DataTypeArray>(&*arguments[1]);
if (!array_type)
throw Exception("Second argument for function " + getName() + " must be array.", ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT);

Expand All @@ -1074,7 +1020,7 @@ void FunctionReplicate::executeImpl(Block & block, const ColumnNumbers & argumen
{
ColumnPtr first_column = block.getByPosition(arguments[0]).column;

const ColumnArray * array_column = checkAndGetColumn<ColumnArray>(block.getByPosition(arguments[1]).column.get());
const auto * array_column = checkAndGetColumn<ColumnArray>(block.getByPosition(arguments[1]).column.get());
ColumnPtr temp_column;

if (!array_column)
Expand Down Expand Up @@ -1136,8 +1082,8 @@ class FunctionBar : public IFunction

void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result) const override
{
Int64 min = extractConstant<Int64>(block, arguments, 1, "Second"); /// The level at which the line has zero length.
Int64 max = extractConstant<Int64>(block, arguments, 2, "Third"); /// The level at which the line has the maximum length.
auto min = extractConstant<Int64>(block, arguments, 1, "Second"); /// The level at which the line has zero length.
auto max = extractConstant<Int64>(block, arguments, 2, "Third"); /// The level at which the line has the maximum length.

/// The maximum width of the bar in characters, by default.
Float64 max_width = arguments.size() == 4 ? extractConstant<Float64>(block, arguments, 3, "Fourth") : 80;
Expand Down Expand Up @@ -1220,7 +1166,7 @@ class FunctionBar : public IFunction
template <typename T>
static bool executeNumber(const IColumn & src, ColumnString & dst, Int64 min, Int64 max, Float64 max_width)
{
if (const ColumnVector<T> * col = checkAndGetColumn<ColumnVector<T>>(&src))
if (const auto * col = checkAndGetColumn<ColumnVector<T>>(&src))
{
fill(col->getData(), dst.getChars(), dst.getOffsets(), min, max, max_width);
return true;
Expand Down Expand Up @@ -1512,7 +1458,7 @@ class FunctionRunningAccumulate : public IFunction

DataTypePtr getReturnTypeImpl(const DataTypes & arguments) const override
{
const DataTypeAggregateFunction * type = checkAndGetDataType<DataTypeAggregateFunction>(&*arguments[0]);
const auto * type = checkAndGetDataType<DataTypeAggregateFunction>(&*arguments[0]);
if (!type)
throw Exception("Argument for function " + getName() + " must have type AggregateFunction - state of aggregate function.",
ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT);
Expand All @@ -1522,7 +1468,7 @@ class FunctionRunningAccumulate : public IFunction

void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result) const override
{
const ColumnAggregateFunction * column_with_states
const auto * column_with_states
= typeid_cast<const ColumnAggregateFunction *>(&*block.getByPosition(arguments.at(0)).column);
if (!column_with_states)
throw Exception("Illegal column " + block.getByPosition(arguments.at(0)).column->getName()
Expand All @@ -1535,9 +1481,9 @@ class FunctionRunningAccumulate : public IFunction

auto deleter = [&agg_func](char * ptr) {
agg_func.destroy(ptr);
free(ptr);
free(ptr); // NOLINT(cppcoreguidelines-no-malloc)
};
std::unique_ptr<char, decltype(deleter)> place{reinterpret_cast<char *>(malloc(agg_func.sizeOfData())), deleter};
std::unique_ptr<char, decltype(deleter)> place{reinterpret_cast<char *>(malloc(agg_func.sizeOfData())), deleter}; // NOLINT(cppcoreguidelines-no-malloc)

agg_func.create(place.get()); /// Not much exception-safe. If an exception is thrown out, destroy will be called in vain.

Expand Down Expand Up @@ -1724,7 +1670,7 @@ class FunctionFinalizeAggregation : public IFunction

DataTypePtr getReturnTypeImpl(const DataTypes & arguments) const override
{
const DataTypeAggregateFunction * type = checkAndGetDataType<DataTypeAggregateFunction>(&*arguments[0]);
const auto * type = checkAndGetDataType<DataTypeAggregateFunction>(&*arguments[0]);
if (!type)
throw Exception("Argument for function " + getName() + " must have type AggregateFunction - state of aggregate function.",
ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT);
Expand All @@ -1734,7 +1680,7 @@ class FunctionFinalizeAggregation : public IFunction

void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result) const override
{
const ColumnAggregateFunction * column_with_states
const auto * column_with_states
= typeid_cast<const ColumnAggregateFunction *>(&*block.getByPosition(arguments.at(0)).column);
if (!column_with_states)
throw Exception("Illegal column " + block.getByPosition(arguments.at(0)).column->getName()
Expand Down Expand Up @@ -1967,7 +1913,6 @@ void registerFunctionsMiscellaneous(FunctionFactory & factory)
factory.registerFunction<FunctionIgnore>();
factory.registerFunction<FunctionIndexHint>();
factory.registerFunction<FunctionIdentity>();
factory.registerFunction<FunctionArrayJoin>();
factory.registerFunction<FunctionReplicate>();
factory.registerFunction<FunctionBar>();
factory.registerFunction<FunctionHasColumnInTable>();
Expand Down
Loading

0 comments on commit 81660bd

Please sign in to comment.