Interpreter: Remove Table properties query (#4586)

ref #4860
pingcap · May 12, 2022 · ace1369 · ace1369
1 parent c49258b
commit ace1369
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 307 deletions.
diff --git a/dbms/src/Interpreters/InterpreterFactory.cpp b/dbms/src/Interpreters/InterpreterFactory.cpp
@@ -27,7 +27,6 @@
 #include <Interpreters/InterpreterSelectQuery.h>
 #include <Interpreters/InterpreterSelectWithUnionQuery.h>
 #include <Interpreters/InterpreterSetQuery.h>
-#include <Interpreters/InterpreterShowCreateQuery.h>
 #include <Interpreters/InterpreterShowProcesslistQuery.h>
 #include <Interpreters/InterpreterShowTablesQuery.h>
 #include <Interpreters/InterpreterSystemQuery.h>
@@ -122,14 +121,6 @@ std::unique_ptr<IInterpreter> InterpreterFactory::get(ASTPtr & query, Context &
     {
         return std::make_unique<InterpreterExistsQuery>(query, context);
     }
-    else if (typeid_cast<ASTShowCreateTableQuery *>(query.get()))
-    {
-        return std::make_unique<InterpreterShowCreateQuery>(query, context);
-    }
-    else if (typeid_cast<ASTShowCreateDatabaseQuery *>(query.get()))
-    {
-        return std::make_unique<InterpreterShowCreateQuery>(query, context);
-    }
     else if (typeid_cast<ASTDescribeQuery *>(query.get()))
     {
         return std::make_unique<InterpreterDescribeQuery>(query, context);

diff --git a/dbms/src/Interpreters/InterpreterShowCreateQuery.cpp b/dbms/src/Interpreters/InterpreterShowCreateQuery.cpp
diff --git a/dbms/src/Interpreters/InterpreterShowCreateQuery.h b/dbms/src/Interpreters/InterpreterShowCreateQuery.h
diff --git a/dbms/src/Parsers/ParserQueryWithOutput.cpp b/dbms/src/Parsers/ParserQueryWithOutput.cpp
@@ -21,16 +21,13 @@
 #include <Parsers/ParserSelectWithUnionQuery.h>
 #include <Parsers/ParserShowProcesslistQuery.h>
 #include <Parsers/ParserShowTablesQuery.h>
-#include <Parsers/ParserTablePropertiesQuery.h>
-
 
 namespace DB
 {
 bool ParserQueryWithOutput::parseImpl(Pos & pos, ASTPtr & node, Expected & expected)
 {
     ParserShowTablesQuery show_tables_p;
     ParserSelectWithUnionQuery select_p;
-    ParserTablePropertiesQuery table_p;
     ParserDescribeTableQuery describe_table_p;
     ParserShowProcesslistQuery show_processlist_p;
     ParserCreateQuery create_p;
@@ -42,7 +39,6 @@ bool ParserQueryWithOutput::parseImpl(Pos & pos, ASTPtr & node, Expected & expec
 
     bool parsed = select_p.parse(pos, query, expected)
         || show_tables_p.parse(pos, query, expected)
-        || table_p.parse(pos, query, expected)
         || describe_table_p.parse(pos, query, expected)
         || show_processlist_p.parse(pos, query, expected)
         || create_p.parse(pos, query, expected)

diff --git a/dbms/src/Parsers/ParserTablePropertiesQuery.cpp b/dbms/src/Parsers/ParserTablePropertiesQuery.cpp
diff --git a/dbms/src/Parsers/ParserTablePropertiesQuery.h b/dbms/src/Parsers/ParserTablePropertiesQuery.h
diff --git a/dbms/src/Parsers/TablePropertiesQueriesASTs.h b/dbms/src/Parsers/TablePropertiesQueriesASTs.h
@@ -19,43 +19,19 @@
 
 namespace DB
 {
-
 struct ASTExistsQueryIDAndQueryNames
 {
     static constexpr auto ID = "ExistsQuery";
     static constexpr auto Query = "EXISTS TABLE";
 };
 
-struct ASTShowCreateTableQueryIDAndQueryNames
-{
-    static constexpr auto ID = "ShowCreateTableQuery";
-    static constexpr auto Query = "SHOW CREATE TABLE";
-};
-
-struct ASTShowCreateDatabaseQueryIDAndQueryNames
-{
-    static constexpr auto ID = "ShowCreateDatabaseQuery";
-    static constexpr auto Query = "SHOW CREATE DATABASE";
-};
-
 struct ASTDescribeQueryExistsQueryIDAndQueryNames
 {
     static constexpr auto ID = "DescribeQuery";
     static constexpr auto Query = "DESCRIBE TABLE";
 };
 
 using ASTExistsQuery = ASTQueryWithTableAndOutputImpl<ASTExistsQueryIDAndQueryNames>;
-using ASTShowCreateTableQuery = ASTQueryWithTableAndOutputImpl<ASTShowCreateTableQueryIDAndQueryNames>;
-
-class ASTShowCreateDatabaseQuery : public ASTQueryWithTableAndOutputImpl<ASTShowCreateDatabaseQueryIDAndQueryNames>
-{
-protected:
-    void formatQueryImpl(const FormatSettings & settings, FormatState &, FormatStateStacked) const override
-    {
-        settings.ostr << (settings.hilite ? hilite_keyword : "") << ASTShowCreateDatabaseQueryIDAndQueryNames::Query
-                      << " " << (settings.hilite ? hilite_none : "") << backQuoteIfNeed(database);
-    }
-};
 
 class ASTDescribeQuery : public ASTQueryWithOutput
 {
@@ -84,7 +60,6 @@ class ASTDescribeQuery : public ASTQueryWithOutput
                       << "DESCRIBE TABLE " << (settings.hilite ? hilite_none : "");
         table_expression->formatImpl(settings, state, frame);
     }
-
 };
 
-}
+} // namespace DB