Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh, en: add primary/unique key check description (#223) #240

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #223 to release-1.0


What is changed, added or deleted? (Required)

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v2.0 changes for now)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

dm#887 dm#870

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ti-srebot ti-srebot added the type/cherry-pick-for-release-1.0 This PR is cherry-picked to release-1.0 from a source PR. label Aug 17, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2020
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Aug 17, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@ireneontheway ireneontheway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor Author

@ireneontheway,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ti-srebot ti-srebot merged commit fc367ab into pingcap:release-1.0 Aug 17, 2020
@ireneontheway ireneontheway deleted the release-1.0-6093817462d2 branch August 17, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-1.0 This PR is cherry-picked to release-1.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants