Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

precheck: support primary/unique key check #870 #887

Merged
merged 2 commits into from
Aug 13, 2020
Merged

precheck: support primary/unique key check #870 #887

merged 2 commits into from
Aug 13, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Aug 12, 2020

What problem does this PR solve?

manually cherrypick #870

What is changed and how it works?

update tidb-tools and fix some tests

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #887 into release-1.0 will increase coverage by 0.4792%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-1.0       #887        +/-   ##
===================================================
+ Coverage      57.2665%   57.7458%   +0.4792%     
===================================================
  Files              161        168         +7     
  Lines            16741      17177       +436     
===================================================
+ Hits              9587       9919       +332     
- Misses            6206       6292        +86     
- Partials           948        966        +18

@lance6716
Copy link
Collaborator

how about test ignore-checking-items could work

rest LGTM

@GMHDBJD GMHDBJD added status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Aug 13, 2020
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Aug 13, 2020

how about test ignore-checking-items could work

The origin commit failed because doesn't have primary key. I think it's enough. 🤣

@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Aug 13, 2020
csuzhangxc
csuzhangxc approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Aug 13, 2020
@csuzhangxc csuzhangxc added this to the v1.0.7 milestone Aug 13, 2020
@lance6716 lance6716 removed the status/PTAL This PR is ready for review. Add this label back after committing new changes label Aug 13, 2020
@GMHDBJD GMHDBJD merged commit cd0ea4b into pingcap:release-1.0 Aug 13, 2020
@GMHDBJD GMHDBJD mentioned this pull request Aug 13, 2020
Merged
6 tasks
@ti-srebot ti-srebot mentioned this pull request Aug 17, 2020
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v1.0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@GMHDBJD @lance6716 @csuzhangxc @ti-srebot