Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

precheck: support primary/unique key check #870

Merged
merged 7 commits into from
Aug 10, 2020
Merged

precheck: support primary/unique key check #870

merged 7 commits into from
Aug 10, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Aug 7, 2020

What problem does this PR solve?

close #788

What is changed and how it works?

update tidb-tools and fix some tests

Tests

  • Manual test (add detailed scripts or steps below)

@GMHDBJD GMHDBJD added priority/normal Minor change, requires approval from ≥1 primary reviewer type/feature New feature needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Aug 7, 2020
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Aug 7, 2020

/run-all-tests

@codecov
Copy link

codecov bot commented Aug 7, 2020 •
edited
Loading

Codecov Report

Merging #870 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #870   +/-   ##
===========================================
  Coverage   56.0502%   56.0502%           
===========================================
  Files           220        220           
  Lines         22867      22867           
===========================================
  Hits          12817      12817           
  Misses         8736       8736           
  Partials       1314       1314

@GMHDBJD GMHDBJD added the status/PTAL This PR is ready for review. Add this label back after committing new changes label Aug 7, 2020
@GMHDBJD GMHDBJD requested review from lance6716 and csuzhangxc August 7, 2020 06:35
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Aug 7, 2020
@lance6716 lance6716 removed the status/PTAL This PR is ready for review. Add this label back after committing new changes label Aug 7, 2020
csuzhangxc
csuzhangxc previously approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW, can we also add PK to test data to fix cases, right?

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Aug 7, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC milestone Aug 7, 2020
@GMHDBJD GMHDBJD added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/LGT2 Two reviewers already commented LGTM, ready for merge labels Aug 10, 2020
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Aug 10, 2020

Have added PK to test data, PTAL again. @csuzhangxc @lance6716

@lance6716
Copy link
Collaborator

LGTM

@lance6716 lance6716 added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Aug 10, 2020
csuzhangxc
csuzhangxc approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD merged commit 3730a4e into pingcap:master Aug 10, 2020
@GMHDBJD GMHDBJD deleted the PKUKcheck branch August 10, 2020 04:09
@ti-srebot
Copy link

cherry pick to release-1.0 failed

GMHDBJD added a commit to GMHDBJD/dm that referenced this pull request Aug 12, 2020
@GMHDBJD
precheck: support primary/unique key check pingcap#870
182d478
@GMHDBJD GMHDBJD mentioned this pull request Aug 12, 2020
Merged
GMHDBJD added a commit that referenced this pull request Aug 13, 2020
@GMHDBJD
precheck: support primary/unique key check #870 (#887)
cd0ea4b
@lance6716 lance6716 added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Aug 13, 2020
@GMHDBJD GMHDBJD mentioned this pull request Aug 13, 2020
Merged
6 tasks
@ti-srebot ti-srebot mentioned this pull request Aug 17, 2020
Merged
6 tasks
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/feature New feature
Projects
None yet
Milestone
v2.0.0 RC
Development

Successfully merging this pull request may close these issues.

Check PK/UK exists before starting the task
4 participants
@GMHDBJD @lance6716 @ti-srebot @csuzhangxc