zh, en: add primary/unique key check description #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csuzhangxc
reviewed
Aug 13, 2020
zh/precheck.md
Outdated
| @@ -43,6 +43,8 @@ aliases: ['/docs-cn/tidb-data-migration/dev/precheck/'] | |||
| - TiDB 不支持外键 | |||
| - 字符集的兼容性不同，详见 [TiDB 支持的字符集](https://pingcap.com/docs-cn/dev/reference/sql/character-set/) | |||
|
|
|||
| DM 还会检查上游表中是否存在主键或 Unique 约束, 在 v1.0.7 版本引入 | |||
There was a problem hiding this comment.
统一一下 主键 和 Unique 的中英文表述？比如直接说 主键或唯一键？
There was a problem hiding this comment.
address in 27d4eb3
ireneontheway
added
needs-cherry-pick-release-1.0
ireneontheway
suggested changes
Aug 13, 2020
Co-authored-by: ireneontheway <[email protected]>
|
@ireneontheway,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack). |
Co-authored-by: ireneontheway <[email protected]>
|
@TomShawn two LGTM now, PTAL |
TomShawn
reviewed
Aug 17, 2020
TomShawn
reviewed
Aug 17, 2020
TomShawn
added
require-LGT1
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/docs-dm
that referenced
this pull request
Aug 17, 2020
Signed-off-by: ti-srebot <[email protected]>
6 tasks
|
cherry pick to release-1.0 in PR #240 |
ti-srebot
added a commit
that referenced
this pull request
Aug 17, 2020
Signed-off-by: ti-srebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Which DM version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
dm#887 dm#870
Do your changes match any of the following descriptions?