Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource_control: updates some changes about resource group in 7.0 #13310

Merged
merged 29 commits into from
Mar 24, 2023
Merged

resource_control: updates some changes about resource group in 7.0 #13310

merged 29 commits into from
Mar 24, 2023

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Mar 7, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add document for SQL statments SET RESOURCE GROUP, CURRENT_RESOURCE_GROUP() function and RESOURCE_GROUP() hint.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd
  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 7, 2023 06:49
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2023
@glorv glorv requested review from nolouch, BornChanger and ran-huang and removed request for TomShawn March 7, 2023 06:49
@TomShawn TomShawn requested review from hfxsd and removed request for ran-huang March 7, 2023 06:50
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. v7.0 and removed missing-translation-status This PR does not have translation status info. labels Mar 7, 2023
hfxsd
hfxsd reviewed Mar 10, 2023
View reviewed changes
optimizer-hints.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Mar 10, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Mar 10, 2023
View reviewed changes
optimizer-hints.md Outdated Show resolved Hide resolved
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 22, 2023
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 23, 2023
qiancai
qiancai reviewed Mar 23, 2023
View reviewed changes
information-schema/information-schema-resource-groups.md Outdated Show resolved Hide resolved
optimizer-hints.md Outdated Show resolved Hide resolved
pd-configuration-file.md Outdated Show resolved Hide resolved
pd-configuration-file.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-resource-group.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-set-resource-group.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
information-schema/information-schema-resource-groups.md Show resolved Hide resolved
qiancai
qiancai approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2023
@hfxsd
Copy link
Collaborator

hfxsd commented Mar 24, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3a73128

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@hfxsd
Copy link
Collaborator

hfxsd commented Mar 24, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: abd34e8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@ti-chi-bot ti-chi-bot merged commit f772527 into pingcap:master Mar 24, 2023
@glorv glorv deleted the set-resource-group branch June 21, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@nolouch nolouch nolouch approved these changes

@qiancai qiancai qiancai approved these changes

@songrijie songrijie songrijie approved these changes

@BornChanger BornChanger Awaiting requested review from BornChanger

@easonn7 easonn7 Awaiting requested review from easonn7

Assignees

@hfxsd hfxsd

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@glorv @ti-chi-bot @hfxsd @nolouch @songrijie @qiancai @TomShawn @Connor1996