-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support resource_group sql hint #41678
Conversation
Signed-off-by: BornChanger <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
Signed-off-by: BornChanger <[email protected]>
planner/optimize.go
Outdated
@@ -162,6 +162,15 @@ func Optimize(ctx context.Context, sctx sessionctx.Context, node ast.Node, is in | |||
} | |||
} | |||
|
|||
// Override the resource group if necessary | |||
// TODO: we didn't check the existence of the hinted resource group now to save the cost per query | |||
if originStmtHints.HasResourceGroup && variable.EnableResourceControl.Load() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about :
if originStmtHints.HasResourceGroup {
if variable.EnableResourceControl.Load() {
}
...
}
I think more readable and can reduce once if judged for normal situations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Signed-off-by: BornChanger <[email protected]>
/retest |
/retest |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: be210d8
|
What problem does this PR solve?
Issue Number: close #41676
Problem Summary:
What is changed and how it works?
Via this pr, resource control can support resource _group hint, here is an example
select /*+ resource_group(rg1) */ * from t1;
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.