session: support set current session's resource group name #41722

glorv · 2023-02-24T09:04:41Z

What problem does this PR solve?

Issue Number: ref #38825

Problem Summary:

What is changed and how it works?

Add following two sql:

SET RESOURCE GROUP <name>; to change the resource group of the current session
SELECT current_resource_group(); to return the resource group of the current session
Support set resource group name for the current session.

NOTE: currently, we don't do privilege for this statement. Will do it in the future version.

Check List

Tests

Unit test

Side effects

Documentation

Contains syntax changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support change and return the resource group name of current session.

ti-chi-bot · 2023-02-24T09:04:43Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JmPotato
nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

nolouch

lgtm

nolouch · 2023-02-28T09:57:43Z

ptal @tiancaiamao @BornChanger

…-rg-name

parser/parser.y

BornChanger · 2023-03-02T03:11:11Z

executor/simple_test.go

@@ -133,3 +133,17 @@ func TestUserAttributes(t *testing.T) {
 	rootTK.MustExec("alter user usr1 resource group rg1")
 	rootTK.MustQuery("select user_attributes from mysql.user where user = 'usr1'").Check(testkit.Rows(`{"metadata": {"comment": "comment1"}, "resource_group": "rg1"}`))
 }
+
+func TestSetResourceGroup(t *testing.T) {


Please add case to verify hint overrides session setting and session setting override use binding.

…-rg-name

glorv · 2023-03-02T12:18:26Z

@nolouch I have added support for SELECT CURRENT_RESOURCE_GROUP();, so PTAL again, thanks~

glorv · 2023-03-03T02:38:42Z

/test unit-test

…-rg-name

glorv · 2023-03-03T06:16:30Z

/test check-dev

glorv · 2023-03-03T06:39:09Z

/build

glorv · 2023-03-03T09:11:16Z

@tiancaiamao PTAL, as this PR has introduced a new builtin function.

…-rg-name

glorv · 2023-03-06T02:42:27Z

/test unit-test

tiancaiamao · 2023-03-06T07:56:11Z

parser/parser.y

+	currentTs            "CURRENT_TIMESTAMP"
+	currentUser          "CURRENT_USER"
+	currentRole          "CURRENT_ROLE"
+	currentResourceGroup "CURRENT_RESOURCE_GROUP"


MySQL does not have CURRENT_RESOURCE_GROUP as a reserved keyword https://dev.mysql.com/doc/refman/8.0/en/keywords.html

Maybe we can make it non-keyword...
The different is that you can't create table CURRENT_RESOURCE_GROUP (...) after this change.

But the current way is still OK to me, since it follows the CURRENT_XXX as reserved keyword convention in MySQL

Oh, yes, I think we can make it a non-keyword, so the compatibility should be better.

glorv · 2023-03-06T09:52:57Z

/test build

glorv · 2023-03-06T10:33:39Z

/merge

ti-chi-bot · 2023-03-06T10:33:43Z

This pull request has been accepted and is ready to merge.

Commit hash: 17c9d01

glorv · 2023-03-06T10:35:11Z

/test build

ti-chi-bot · 2023-03-06T10:35:13Z

@glorv: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test unit-test

Use /test all to run all jobs.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

glorv · 2023-03-06T10:36:03Z

/test build

glorv · 2023-03-06T11:49:42Z

/test unit-test

…-rg-name

glorv · 2023-03-06T12:56:43Z

/merge

ti-chi-bot · 2023-03-06T12:56:47Z

This pull request has been accepted and is ready to merge.

Commit hash: 6960de8

glorv · 2023-03-06T14:29:51Z

/test unit-test

support set current session's resource group name

bc2bbc0

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 24, 2023

glorv requested review from nolouch and BornChanger February 24, 2023 09:08

fix format

01a0d4b

nolouch approved these changes Feb 28, 2023

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 28, 2023

nolouch requested a review from tiancaiamao February 28, 2023 09:57

glorv added 5 commits February 28, 2023 18:13

update go mode

55026f7

fix mode pd-client

553e802

Merge branch 'master' of https://github.com/pingcap/tidb into session…

a45bf1e

…-rg-name

fix build

5f5df6b

update bzl

030b778

BornChanger reviewed Mar 2, 2023

View reviewed changes

parser/parser.y Show resolved Hide resolved

BornChanger reviewed Mar 2, 2023

View reviewed changes

glorv added 2 commits March 2, 2023 12:37

Merge branch 'master' of https://github.com/pingcap/tidb into session…

79a12a8

…-rg-name

support select current_resource_group()

aa3c498

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 2, 2023

glorv added 2 commits March 2, 2023 20:30

fix test

42b04ba

fix vec test

7ce5021

glorv force-pushed the session-rg-name branch from da44739 to 7ce5021 Compare March 3, 2023 02:03

Merge branch 'master' of https://github.com/pingcap/tidb into session…

2281510

…-rg-name

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 3, 2023

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2023

Merge branch 'master' of https://github.com/pingcap/tidb into session…

cfd6c20

…-rg-name

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2023

tiancaiamao approved these changes Mar 6, 2023

View reviewed changes

glorv added 2 commits March 6, 2023 16:59

make current_resource_group not a keyword

b5d373f

fix test

17c9d01

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 6, 2023

glorv added 2 commits March 6, 2023 20:49

Merge branch 'master' of https://github.com/pingcap/tidb into session…

5e34876

…-rg-name

fix resource group name hint

6960de8

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 6, 2023

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 6, 2023

ti-chi-bot merged commit 7cd2029 into pingcap:master Mar 6, 2023

glorv mentioned this pull request Mar 7, 2023

resource_control: updates some changes about resource group in 7.0 pingcap/docs-cn#13310

Merged

16 tasks

djshow832 mentioned this pull request Apr 10, 2023

sessionctx: support encoding resource group name into session states #42886

Merged

12 tasks

HuSharp mentioned this pull request Jul 11, 2023

lightning: mark background and resource group name when in local mode #44950

Merged

1 task

glorv deleted the session-rg-name branch December 15, 2023 08:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

session: support set current session's resource group name #41722

session: support set current session's resource group name #41722

glorv commented Feb 24, 2023 •

edited

Loading

ti-chi-bot commented Feb 24, 2023 •

edited

Loading

nolouch left a comment

nolouch commented Feb 28, 2023

BornChanger Mar 2, 2023

glorv Mar 2, 2023

glorv commented Mar 2, 2023

glorv commented Mar 3, 2023

glorv commented Mar 3, 2023

glorv commented Mar 3, 2023

glorv commented Mar 3, 2023

glorv commented Mar 6, 2023

tiancaiamao Mar 6, 2023

glorv Mar 6, 2023

glorv commented Mar 6, 2023

glorv commented Mar 6, 2023

ti-chi-bot commented Mar 6, 2023

glorv commented Mar 6, 2023

ti-chi-bot commented Mar 6, 2023

glorv commented Mar 6, 2023

glorv commented Mar 6, 2023

glorv commented Mar 6, 2023

ti-chi-bot commented Mar 6, 2023

glorv commented Mar 6, 2023

session: support set current session's resource group name #41722

session: support set current session's resource group name #41722

Conversation

glorv commented Feb 24, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Feb 24, 2023 • edited Loading

nolouch left a comment

Choose a reason for hiding this comment

nolouch commented Feb 28, 2023

BornChanger Mar 2, 2023

Choose a reason for hiding this comment

glorv Mar 2, 2023

Choose a reason for hiding this comment

glorv commented Mar 2, 2023

glorv commented Mar 3, 2023

glorv commented Mar 3, 2023

glorv commented Mar 3, 2023

glorv commented Mar 3, 2023

glorv commented Mar 6, 2023

tiancaiamao Mar 6, 2023

Choose a reason for hiding this comment

glorv Mar 6, 2023

Choose a reason for hiding this comment

glorv commented Mar 6, 2023

glorv commented Mar 6, 2023

ti-chi-bot commented Mar 6, 2023

glorv commented Mar 6, 2023

ti-chi-bot commented Mar 6, 2023

glorv commented Mar 6, 2023

glorv commented Mar 6, 2023

glorv commented Mar 6, 2023

ti-chi-bot commented Mar 6, 2023

glorv commented Mar 6, 2023

glorv commented Feb 24, 2023 •

edited

Loading

ti-chi-bot commented Feb 24, 2023 •

edited

Loading