Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

common: adjust config in task RunBackup/RunRestore #443

Merged
merged 1 commit into from
Jul 27, 2020
Merged

common: adjust config in task RunBackup/RunRestore #443

merged 1 commit into from
Jul 27, 2020

Conversation

3pointer
Copy link
Collaborator

@3pointer 3pointer commented Jul 27, 2020 •
edited
Loading

What problem does this PR solve?

The only common entrance of BR binary and BR in TiDB is task.RunXXX.
and we should adjust related config in this function for both binary and TiDB

What is changed and how it works?

Add adjustBackupConfig for task.RunBackup
Add adjustRestoreConfig for task.RunRestore

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note

@3pointer 3pointer requested review from kennytm and glorv July 27, 2020 03:59
@glorv
Copy link
Collaborator

glorv commented Jul 27, 2020

LGTM

@ti-srebot
Copy link
Contributor

@glorv,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: tools(slack).

kennytm
kennytm approved these changes Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Jul 27, 2020
@3pointer 3pointer merged commit a475692 into pingcap:master Jul 27, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 failed

@ti-srebot ti-srebot mentioned this pull request Jul 27, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #444

This was referenced Jul 28, 2020
Merged
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm approved these changes

@glorv glorv Awaiting requested review from glorv

Assignees
No one assigned
Labels
needs-cherry-pick-release-3.1 needs-cherry-pick-release-4.0 status/LGT1 LGTM1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@3pointer @glorv @ti-srebot @kennytm