Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

common: adjust config in task RunBackup/RunRestore (#443) #444

Merged
merged 1 commit into from
Jul 27, 2020
Merged

common: adjust config in task RunBackup/RunRestore (#443) #444

merged 1 commit into from
Jul 27, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #443 to release-4.0

What problem does this PR solve?

The only common entrance of BR binary and BR in TiDB is task.RunXXX.
and we should adjust related config in this function for both binary and TiDB

What is changed and how it works?

Add adjustBackupConfig for task.RunBackup
Add adjustRestoreConfig for task.RunRestore

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note

@ti-srebot ti-srebot mentioned this pull request Jul 27, 2020
Merged
@ti-srebot ti-srebot requested review from glorv and kennytm July 27, 2020 09:28
kennytm
kennytm reviewed Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Jul 27, 2020
@3pointer
Copy link
Collaborator

/run-all-tests

glorv
glorv approved these changes Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor Author

@glorv,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: tools(slack).

@3pointer 3pointer merged commit 01392e4 into pingcap:release-4.0 Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm left review comments

@glorv glorv glorv approved these changes

Assignees
No one assigned
Labels
status/LGT1 LGTM1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @3pointer @kennytm @glorv