Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brie: add integration test for br (#18797) #18835

Merged
merged 4 commits into from
Jul 29, 2020
Merged

brie: add integration test for br (#18797) #18835

merged 4 commits into from
Jul 29, 2020

Conversation

3pointer
Copy link
Contributor

cherry-pick #18797 to release-4.0

What problem does this PR solve?

Problem Summary: add BR integration for TiDB

What is changed and how it works?

What's Changed:

  1. BR only work on tikv store. so add a test in session_test which has tikv store.
  2. Since common: adjust config in task RunBackup/RunRestore br#443 handle all BR related configurations internally, we can remove useless setting config code

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Release note

  • No release note

@overvenus
Copy link
Member

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2020
@github-actions github-actions bot added the sig/execution SIG execution label Jul 28, 2020
@jebter jebter requested review from tangenta and glorv July 28, 2020 21:54
@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 29, 2020
@bb7133
Copy link
Member

bb7133 commented Jul 29, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 29, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit a8be399 into pingcap:release-4.0 Jul 29, 2020
3pointer added a commit to 3pointer/tidb that referenced this pull request Jul 29, 2020
@3pointer @jebter
brie: add integration test for br (pingcap#18797) (pingcap#18835)
2184df8 
Co-authored-by: jebter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@tangenta tangenta Awaiting requested review from tangenta

@glorv glorv Awaiting requested review from glorv

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@3pointer @overvenus @tiancaiamao @bb7133 @ti-srebot @jebter