brie: add integration test for br #18797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3pointer
force-pushed
the
add_integration_test_for_br
branch
from
12eb04e to
24df6cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #18797 +/- ##
===========================================
Coverage 79.2275% 79.2275%
===========================================
Files 545 545
Lines 147840 147840
===========================================
Hits 117130 117130
Misses 21305 21305
Partials 9405 9405 |
3pointer
force-pushed
the
add_integration_test_for_br
branch
from
36282bb to
5fa4aae
Compare
|
/run-check_dev_2 |
3pointer
force-pushed
the
add_integration_test_for_br
branch
from
02d31cb to
92e6461
Compare
|
/run-check_dev_2 |
tiancaiamao
reviewed
Jul 28, 2020
session/session_test.go
Outdated
|
|
||
| tk.MustQuery("select count(*) from t1").Check(testkit.Rows("3")) | ||
|
|
||
| os.RemoveAll("/tmp/bk1") |
There was a problem hiding this comment.
How about using API like os.TempDir and path.Join to make the code more general?
3pointer
force-pushed
the
add_integration_test_for_br
branch
from
2bf9ad1 to
53e75d3
Compare
|
/run-check_dev_2 |
|
LGTM |
|
lgtm |
|
LGTM |
|
@overvenus,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: execution(slack). |
jebter
approved these changes
Jul 28, 2020
|
/merge |
|
/merge |
|
@zz-jason Oops! This PR requires at least 2 LGTMs to merge. The current number of |
ti-srebot
approved these changes
Jul 28, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
3pointer
added a commit
to 3pointer/tidb
that referenced
this pull request
Jul 28, 2020
ti-srebot
pushed a commit
that referenced
this pull request
Jul 29, 2020
Co-authored-by: jebter <[email protected]>
3pointer
added a commit
to 3pointer/tidb
that referenced
this pull request
Jul 29, 2020
Co-authored-by: jebter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary: add BR integration for TiDB
What is changed and how it works?
What's Changed:
Related changes
Check List
Tests
Release note