Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PEAR by default #3781

Closed
wants to merge 1 commit into from
Closed

Conversation

nikic
Copy link
Member

@nikic nikic commented Feb 1, 2019

No description provided.

@KalleZ
Copy link
Member

KalleZ commented Feb 1, 2019

About time we go forward with this, +1

@@ -1136,8 +1136,7 @@ if test "$PHP_CLI" = "no"; then
fi

PHP_ARG_WITH(pear, [whether to install PEAR],
[ --with-pear=DIR Install PEAR in DIR @<:@PREFIX/lib/php@:>@
--without-pear Do not install PEAR], DEFAULT, yes)
[ --with-pear=DIR Install PEAR in DIR @<:@PREFIX/lib/php@:>@], no, yes)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO:

Suggested change
[ --with-pear=DIR Install PEAR in DIR @<:@PREFIX/lib/php@:>@], no, yes)
[ --with-pear=DIR Install PEAR in DIR @<:@PREFIX/lib/php@:>@ (deprecated)], no, yes)

...

@dbalabka
Copy link

dbalabka commented Feb 5, 2019

I have faced with the issue that PECL is part of PEAR and not sure there is a way to install it separately. Hope disabling PEAR is a short term solution

@nikic
Copy link
Member Author

nikic commented Feb 11, 2019

Merged as e93d6d9 together with a deprecation warning.

@torinaki No, this is not a short-term change. The option to install PEAR as part of the PHP installation process will be removed in the future. PEAR should be installed using go-pear.phar or similar instead. (Just like we don't install Composer as part of the PHP installation either.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants