Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort libs paths, enable pear/pecl, add --enable-gd #47

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Sort libs paths, enable pear/pecl, add --enable-gd #47

merged 2 commits into from
Feb 25, 2020

Conversation

triptec
Copy link
Contributor

@triptec triptec commented Feb 25, 2020

  1. Sort output of locate by length, hoping to get system libs instead of libs bundled with random applications (in my case libjpeg.so, libpng.so bundled in intellij)
  2. Enable pear if pear wasn't explicitly disabled (default has been changed to not install it (Disable PEAR by default php/php-src#3781))
  3. Add --enable-gd as that's the new flag for --with-gd (https://www.php.net/manual/en/migration74.other-changes.php#migration74.other-changes.pkg-config)

@smorimoto smorimoto merged commit 5ceaa81 into asdf-community:master Feb 25, 2020
@smorimoto
Copy link
Member

Thanks @triptec for your contribution!

@smorimoto
Copy link
Member

@all-contributors please add @triptec for code infra

@allcontributors allcontributors bot mentioned this pull request Feb 25, 2020
Merged
@allcontributors
Copy link
Contributor

@imbsky

I've put up a pull request to add @triptec! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smorimoto smorimoto smorimoto approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@triptec @smorimoto