-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP] Upgrade to 8.0 #3655
[PHP] Upgrade to 8.0 #3655
Conversation
@dominikzogg seems that a dependency of yours is not PHP 8 compatible |
@waghanza as i can see, you already saw the open PR: dflydev/dflydev-fig-cookies#39 |
7ed3c74
to
53ce736
Compare
@waghanza the dependency that was not ready for php 8 (dflydev/dflydev-fig-cookies) is ready now, means the chubbyphp-swoole and slim-swoole should run on php8 |
let see what's CI say |
@waghanza it seems that the newly added libevent does not work (all workerman stuff fails) |
You mean
I though this module was required on production |
@waghanza it's much better with the extension (from what I read) but it seems to fail compiling |
And idea @walkor ? As I can see @dominikzogg see that an outdate version of |
@waghanza pecl and pear are not available in php8 by default - see https://externals.io/message/103977 instead of pecl install xxx you have to run mkdir -p /usr/src/php/ext/xxx && curl -fsSL https://pecl.php.net/get/xxx | tar xvz -C "/usr/src/php/ext/xxx" --strip 1 && docker-php-ext-install xxx \ |
However I have access to this command on php8 containers @dominikzogg Having an non-compatible extension is 🆗 since |
yes, but as you can see - /tmp/pear/temp/event/php7 - php7 pear, not 8, so that's why it's grabbing event for a php7 not v3 php8-pear is in community repo on alpine https://pkgs.alpinelinux.org/packages?name=php8-pear&branch=edge btw workerman will work without event, I disabled it in my nano due to php8 pecl shenanigan's ;p will add it later on as well |
@waghanza try command |
It's working, but I prefer avoid this. I think the only solution is to wait |
Thanks @laylatichy. I've made a little fix to containers definitions, so as The changes is in php core, and seems not to be temp : php/php-src#3781 However, I'm a little bit confused about this : a C based extension should not be installed with https://github.com/FriendsOfPHP/pickle in php8 ? |
980aa92
to
a8b755c
Compare
359b794
to
9fab65c
Compare
pickle last time I checked was still in a bit of beta state, we still have to wait for some frameworks here that use laminas deps for example so maybe it'll be ready by then |
seems that |
We should have been noticed by |
@leocavalcante @sy-records I have finished this feature (I have to include |
@niden @leocavalcante @sy-records @laylatichy any idea about https://the-benchmarker.semaphoreci.com/jobs/e95a758b-481a-4311-973c-bef31558de32#L47191 ?
|
@waghanza This occur due missing header, will be fixed in next version. |
@sy-records @leocavalcante @laylatichy @dominikzogg finally ... this the only think is that I use thanks for your awesome contributions to all 🎉 |
Hi,
This
PR
replaces #3606, it upgrade PHP to 8.0Regards,