Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Upgrade containers to 8.0 #3606

Merged
merged 15 commits into from
Dec 26, 2020

Conversation

waghanza
Copy link
Collaborator

Hi,

This PR upgrade PHP to 8.0

Regards,

@waghanza
Copy link
Collaborator Author

@l0gicgate @luoxiaojun1992 @huangzhhui @limingxinleo @dominikzogg @fenric @ruudboon @wolfy-j @48d90782 @jcheron Is your framework compliant (or will be seen) with PHP 8.0 ?


@jcheron @luoxiaojun1992 @fenric May I add you to reviewer in order to notify you of any change that affect your framework ?


I have a full CI with failing cases in https://the-benchmarker.semaphoreci.com/workflows/cb10ef80-08b9-4045-bf3d-f7e129bde0ca

@waghanza waghanza marked this pull request as draft December 14, 2020 20:42
@l0gicgate
Copy link

l0gicgate commented Dec 14, 2020

@waghanza

Slim ^4.7 is PHP 8.0 compatible so should be good to go.
screenshot

I am not in charge of slim-swoole or slim-roadrunner

@fenric
Copy link
Member

fenric commented Dec 14, 2020

Hello @waghanza

Sunrise // PHP packages will be updated this month... I'm not against reviewing... Thx!

@waghanza
Copy link
Collaborator Author

@waghanza

Slim ^4.7 is PHP 8.0 compatible so should be good to go.

Indeed, only failing in swoole because of chubbyphp/chubbyphp-swoole-request-handler
https://the-benchmarker.semaphoreci.com/jobs/b4a4d6ab-6aa6-4794-89c8-cff49e6fffae

@dominikzogg
Copy link
Member

@waghanza on it (swoole) forgot to tag the repository

@dominikzogg
Copy link
Member

@waghanza my framework is php 8.0 ready but not the psr7 implementation (the one from @fenric) i could switch to another if you like

@waghanza
Copy link
Collaborator Author

@waghanza on it (swoole) forgot to tag the repository

feel free to add any change in this branch, via PR for example

@dominikzogg
Copy link
Member

dominikzogg commented Dec 14, 2020

@waghanza swoole and workerman libraries are tagged, should be available soon (should fix the issue with slim-swoole. FYI: @l0gicgate

@limingxinleo
Copy link
Member

Sorry, hyperf does not works in php8.

Better reflection will compliant in january

@luoxiaojun1992
Copy link
Contributor

Elasticsearch sdk is not compatible for php8 now. Maybe I can move it from require section to suggestion and test again.

@waghanza

@dominikzogg
Copy link
Member

@waghanza #3618

@waghanza waghanza mentioned this pull request Dec 21, 2020
@alexpts
Copy link

alexpts commented Dec 22, 2020

You can enable JIT for more performance. Add configuration for opcache.ini config:

opcache.enable_cli=1
opcache.enable=1
opcache.jit_buffer_size=64M
opcache.jit=1255

@waghanza
Copy link
Collaborator Author

Thanks @alexpts for your feedback. I have however some questions :

You can enable JIT for more performance. Add configuration for opcache.ini config:

opcache.enable_cli=1
opcache.enable=1
opcache.jit_buffer_size=64M
opcache.jit=1255

How do you compute buffer size for the not compiler ?
Why this number for opcache.jit ?

@fenric
Copy link
Member

fenric commented Dec 26, 2020

#3654

@waghanza waghanza mentioned this pull request Dec 26, 2020
@waghanza
Copy link
Collaborator Author

Replaced with #3655

waghanza added a commit that referenced this pull request Jan 11, 2021
waghanza added a commit that referenced this pull request Jan 11, 2021
waghanza added a commit that referenced this pull request Jan 11, 2021
waghanza added a commit that referenced this pull request Jan 24, 2021
waghanza added a commit that referenced this pull request Jan 26, 2021
waghanza added a commit that referenced this pull request Feb 1, 2021
waghanza added a commit that referenced this pull request Feb 3, 2021
waghanza added a commit that referenced this pull request Feb 4, 2021
waghanza added a commit that referenced this pull request Feb 6, 2021
waghanza added a commit that referenced this pull request Feb 6, 2021
waghanza added a commit that referenced this pull request Feb 7, 2021
waghanza added a commit that referenced this pull request Feb 9, 2021
waghanza added a commit that referenced this pull request Feb 13, 2021
waghanza added a commit that referenced this pull request Feb 17, 2021
waghanza added a commit that referenced this pull request Feb 19, 2021
waghanza added a commit that referenced this pull request Feb 24, 2021
waghanza added a commit that referenced this pull request Feb 27, 2021
waghanza added a commit that referenced this pull request Mar 2, 2021
waghanza added a commit that referenced this pull request Mar 3, 2021
waghanza added a commit that referenced this pull request Mar 8, 2021
waghanza added a commit that referenced this pull request Mar 18, 2021
waghanza added a commit that referenced this pull request Apr 1, 2021
waghanza added a commit that referenced this pull request Apr 3, 2021
waghanza added a commit that referenced this pull request Apr 15, 2021
waghanza added a commit that referenced this pull request Apr 16, 2021
waghanza added a commit that referenced this pull request Apr 25, 2021
waghanza added a commit that referenced this pull request May 4, 2021
waghanza added a commit that referenced this pull request May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants