Add 7.4.0alpha1 #840
Add 7.4.0alpha1 #840
Conversation
| \ | ||
| && export CFLAGS="$PHP_CFLAGS" \ | ||
| CPPFLAGS="$PHP_CPPFLAGS" \ | ||
| LDFLAGS="$PHP_LDFLAGS" \ |
There was a problem hiding this comment.
| LDFLAGS="$PHP_LDFLAGS" \ | |
| LDFLAGS="$PHP_LDFLAGS" \ | |
| ARGON2_LIBS="-largon2" \ | |
| ARGON2_CFLAGS="-I/usr/include" \ |
Hello, thank you for the PHP 7.4.0 images so soon already in preparation 🎉
Before php/php-src@19e2101 gets fixed more properly there might be an issue with detecting the argon2-dev library using pkgconf tool on Alpine Linux. So until the PHP 7.4.0alpha2 version this might help pass the build step for current PHP 7.4.0alpha1 (if it will get stuck with some pkg-config error about not finding the libargon2...
Other than that I think it looks good. Thank you and have a nice day.
| \ | ||
| && export CFLAGS="$PHP_CFLAGS" \ | ||
| CPPFLAGS="$PHP_CPPFLAGS" \ | ||
| LDFLAGS="$PHP_LDFLAGS" \ |
There was a problem hiding this comment.
| LDFLAGS="$PHP_LDFLAGS" \ | |
| LDFLAGS="$PHP_LDFLAGS" \ | |
| ARGON2_LIBS="-largon2" \ | |
| ARGON2_CFLAGS="-I/usr/include" \ |
Same fix here if the build fails...
| \ | ||
| && export CFLAGS="$PHP_CFLAGS" \ | ||
| CPPFLAGS="$PHP_CPPFLAGS" \ | ||
| LDFLAGS="$PHP_LDFLAGS" \ |
There was a problem hiding this comment.
| LDFLAGS="$PHP_LDFLAGS" \ | |
| LDFLAGS="$PHP_LDFLAGS" \ | |
| ARGON2_LIBS="-largon2" \ | |
| ARGON2_CFLAGS="-I/usr/include" \ |
Same here if the Alpine build fails...
|
@petk !!! Really appreciate your comments and review! 👍 ❤️ ❤️ @yosifkit is looking at "oniguruma" (needed for newer mbstring) and the Argon2 bit you mentioned 👍 Another thing we need to grapple with is how to handle https://externals.io/message/103977 / php/php-src#3781 / php/php-src@e93d6d9 ( I think we should probably follow suit in 7.4+ so that we stay faithful to upstream in that regard. 😞 |
|
Hello. The oniguruma library used to be bundled directly in the PHP source code, so now there is one more dependency here:
About the PEAR option being deprecated. This now means that in one of the future versions it won't be posible to install PEAR using directly with PHP anymore. This doesn't mean that PEAR (and its tightly coupled and bundled script pecl) is deprecated itself. There will still be possible to install PEAR manually (which should be the preferred approach). However, both these two tools are very behind the understanding of modern tools for such functionality, yes. Based on PHP directly, currently there isn't any alternative... |
Changes: - docker-library/php@191ca54: Merge pull request docker-library/php#840 from infosiftr/7.4-rc - docker-library/php@a9f19e9: Apply minor changes to non 7.4 versions to make deleting lines easier for 7.4 - docker-library/php@d92a953: Fix build issues on 7.4.0-alpha1 - docker-library/php@3822c17: Update generated README - docker-library/php@3e9d32b: Add 7.4.0alpha1
Changes: - docker-library/php@9687d42: Merge pull request docker-library/php#842 from infosiftr/drop-jessie - docker-library/php@3a3efd8: Drop alpine 3.8 and jessie builds; these were only kept around for users to transition to stretch or 3.9 (see docker-library/php#504) - docker-library/php@191ca54: Merge pull request docker-library/php#840 from infosiftr/7.4-rc - docker-library/php@a9f19e9: Apply minor changes to non 7.4 versions to make deleting lines easier for 7.4 - docker-library/php@d92a953: Fix build issues on 7.4.0-alpha1 - docker-library/php@3822c17: Update generated README - docker-library/php@3e9d32b: Add 7.4.0alpha1
See #825 (comment) 👍
Closes #841