Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly builds of unreleased PHP versions #825

Closed
martinssipenko opened this issue May 7, 2019 · 10 comments
Closed

Nightly builds of unreleased PHP versions #825

martinssipenko opened this issue May 7, 2019 · 10 comments
Labels
Request Request for image modification or feature

Comments

@martinssipenko
Copy link

Hi,

Are there any plans to build nightly snapshot builds of unreleased PHP versions such as 7.4 and 8.0? This would greatly help framework/library/application authors to test their projects against upcoming PHP versions.

@wglambert wglambert added the Request Request for image modification or feature label May 7, 2019
@wglambert
Copy link

docker-library/julia#25 (comment)

Similar issues: docker-library/official-images#1281, rust-lang/docker-rust#5, docker-library/docker#125

Any nightly or dev image in the official images would still need to maintain the repeatability aspect. All builds make heavy use of docker build cache so if the RUN line does not change, the image would not change. Base images get updates and cause dependent images to rebuild and we don't want those situations to cause a version bump to the main software of the image. The only other time an image gets built is via a commit in official-images that changes the respective library/ file. eggdrop is one image that has a develop build that they update once in a while (like docker-library/official-images#3051).

Nightly builds aren't something we can feasibly maintain

@GrahamCampbell
Copy link

Getting PHP 7.4 releases once the PHP core team start doing alpha tags would be great. That way it's not "nightly".

@martinssipenko
Copy link
Author

Fair enough, having having pre-stable releases (alpha, beta, RC) makes more sense. @wglambert do you think this could be achievable?

@GrahamCampbell
Copy link

I'd expect PHP 7.4.0alpha1 to be released either in June or July this year, and then alpha releases to occur every 2 weeks until beta starts, and then beta releases every 2 weeks until RC, just like 7.3 last year. As far as I'm aware, the tentative 7.4.0 stable release date is December this year.

@tianon
Copy link
Member

tianon commented May 13, 2019

That's definitely something we're hip about, and have provided in the past (see also

php/update.sh

Lines 55 to 82 in e63194a

# scrape the relevant API based on whether we're looking for pre-releases
apiUrl="https://www.php.net/releases/index.php?json&max=100&version=${rcVersion%%.*}"
apiJqExpr='
(keys[] | select(startswith("'"$rcVersion"'."))) as $version
| [ $version, (
.[$version].source[]
| select(.filename | endswith(".xz"))
|
"https://www.php.net/get/" + .filename + "/from/this/mirror",
"https://www.php.net/get/" + .filename + ".asc/from/this/mirror",
.sha256 // "",
.md5 // ""
) ]
'
if [ "$rcVersion" != "$version" ]; then
apiUrl='https://qa.php.net/api.php?type=qa-releases&format=json'
apiJqExpr='
.releases[]
| select(.version | startswith("'"$rcVersion"'."))
| [
.version,
.files.xz.path // "",
"",
.files.xz.sha256 // "",
.files.xz.md5 // ""
]
'
fi
for where in update.sh we still have logic for scraping pre-releases).

Once PHP 7.4.0alpha1 drops, we'll be looking to include it. 👍

I'm going to close this though since there's nothing actionable right now given that we really can't do proper nightly builds effectively. That being said, it shouldn't be too hard for someone to take our Dockerfile and create an image that mirrors ours but builds directly from a specific commit from upstream and publish/maintain it under a separate organization for users to consume. 👍

@tianon tianon closed this as completed May 13, 2019
@GrahamCampbell
Copy link

PHP 7.4.0alpha1 has now been released. :)

@tianon
Copy link
Member

tianon commented Jun 12, 2019

I see a tag at https://github.com/php/php-src/blob/php-7.4.0alpha1/NEWS, but no release artifacts at https://qa.php.net/ yet 😕

@tianon
Copy link
Member

tianon commented Jun 12, 2019

Aha, it needs an update to https://github.com/php/web-qa/blob/master/include/release-qa.php before it shows up in the API where we can scrape it properly.

@GrahamCampbell
Copy link

Oh, I see. It'll be appearing there tomorrow I think, in line with the release date. :)

@tianon tianon mentioned this issue Jun 13, 2019
@tianon
Copy link
Member

tianon commented Jun 13, 2019

#840 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Request Request for image modification or feature
Projects
None yet
Development

No branches or pull requests

4 participants